-
Notifications
You must be signed in to change notification settings - Fork 115
Add integration tests for main.js
#56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f37c60c
test: Add test to verify 'main' exits with an error when 'GITHUB_REPO…
smockle 6ffe98f
test: Add tests to verify 'main' overrides 'request'’s default 'baseU…
smockle 0d62a31
Revert "test: Add tests to verify 'main' overrides 'request'’s defaul…
smockle 3bbba10
test: Add tests to verify 'main' gets a token.
smockle f4530b0
chore: Fix 'package-lock.json' after rebase
smockle b6d9941
test: Add tests for 'owner'/'repository' input permutations
smockle a851e91
test: Add tests for 'owner'-as-org/'owner'-as-user input permutations
smockle 953f7f5
fix: DRY the invalidated private key to make tests more concise.
smockle 7fc0201
fix: DRY the common test setup to make tests more concise.
smockle ebc6fac
fix: Remove unused imports
smockle 9776690
docs: Use clearer descriptions of tests
smockle fe08922
docs: Move test scenario description comment for consistency.
smockle f63553c
fix: Make individual tests more explicit.
smockle 39131f2
fix: Make base installation id mock more readable.
smockle 57b2c90
chore: Re-run checks
smockle 1174dff
fix: Set JSON response header
smockle 73aade4
chore: Update ava snapshots
smockle 10b4ea2
fix: Clear Actions environment variables (in tests) that change 'core…
smockle f343cd5
fix: Move Actions env var override, and ensure it’s cleared when test…
smockle 02f90f5
fix: Remove '// @ts-check' in test files, in part to suppress the war…
smockle fabe540
fix: Remove async IIFE wrapper; use top-level 'await'
smockle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // @ts-check | ||
|
|
||
| process.env.GITHUB_REPOSITORY = "actions/create-github-app-token"; | ||
| delete process.env.GITHUB_REPOSITORY_OWNER; | ||
|
|
||
| // Verify `main` exits with an error when `GITHUB_REPOSITORY_OWNER` is missing. | ||
| (async () => { | ||
| try { | ||
| await import("../main.js"); | ||
| } catch (error) { | ||
| console.error(error.message); | ||
| } | ||
| })(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // @ts-check | ||
|
|
||
| delete process.env.GITHUB_REPOSITORY; | ||
|
|
||
| // Verify `main` exits with an error when `GITHUB_REPOSITORY` is missing. | ||
| (async () => { | ||
| try { | ||
| await import("../main.js"); | ||
| } catch (error) { | ||
| console.error(error.message); | ||
| } | ||
| })(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // @ts-check | ||
| import { test } from "./main.js"; | ||
|
|
||
| // Verify `main` successfully obtains a token when the `owner` and `repositories` inputs are set (and the latter is a list of repos). | ||
| await test(() => { | ||
| process.env.INPUT_OWNER = process.env.GITHUB_REPOSITORY_OWNER; | ||
| process.env.INPUT_REPOSITORIES = `${process.env.GITHUB_REPOSITORY},actions/toolkit`; | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // @ts-check | ||
| import { test } from "./main.js"; | ||
|
|
||
| // Verify `main` successfully obtains a token when the `owner` and `repositories` inputs are set (and the latter is a single repo). | ||
| await test(() => { | ||
| process.env.INPUT_OWNER = process.env.GITHUB_REPOSITORY_OWNER; | ||
| process.env.INPUT_REPOSITORIES = process.env.GITHUB_REPOSITORY; | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // @ts-check | ||
| import { test } from "./main.js"; | ||
|
|
||
| // Verify `main` successfully obtains a token when the `owner` input is set (to an org), but the `repositories` input isn’t set. | ||
| await test((mockPool) => { | ||
| process.env.INPUT_OWNER = process.env.GITHUB_REPOSITORY_OWNER; | ||
| delete process.env.INPUT_REPOSITORIES; | ||
|
|
||
| // Mock installation id request | ||
| const mockInstallationId = "123456"; | ||
| mockPool | ||
| .intercept({ | ||
| path: `/orgs/${process.env.INPUT_OWNER}/installation`, | ||
| method: "GET", | ||
| headers: { | ||
| accept: "application/vnd.github.v3+json", | ||
| "user-agent": "actions/create-github-app-token", | ||
| // Intentionally omitting the `authorization` header, since JWT creation is not idempotent. | ||
| }, | ||
| }) | ||
| .reply( | ||
| 200, | ||
| { id: mockInstallationId }, | ||
| { headers: { "content-type": "application/json" } } | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // @ts-check | ||
| import { test } from "./main.js"; | ||
|
|
||
| // Verify `main` successfully obtains a token when the `owner` input is set (to a user), but the `repositories` input isn’t set. | ||
| await test((mockPool) => { | ||
| process.env.INPUT_OWNER = "smockle"; | ||
| delete process.env.INPUT_REPOSITORIES; | ||
|
|
||
| // Mock installation id request | ||
| const mockInstallationId = "123456"; | ||
| mockPool | ||
| .intercept({ | ||
| path: `/orgs/${process.env.INPUT_OWNER}/installation`, | ||
| method: "GET", | ||
| headers: { | ||
| accept: "application/vnd.github.v3+json", | ||
| "user-agent": "actions/create-github-app-token", | ||
| // Intentionally omitting the `authorization` header, since JWT creation is not idempotent. | ||
| }, | ||
| }) | ||
| .reply(404); | ||
| mockPool | ||
| .intercept({ | ||
| path: `/users/${process.env.INPUT_OWNER}/installation`, | ||
| method: "GET", | ||
| headers: { | ||
| accept: "application/vnd.github.v3+json", | ||
| "user-agent": "actions/create-github-app-token", | ||
| // Intentionally omitting the `authorization` header, since JWT creation is not idempotent. | ||
| }, | ||
| }) | ||
| .reply( | ||
| 200, | ||
| { id: mockInstallationId }, | ||
| { headers: { "content-type": "application/json" } } | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // @ts-check | ||
| import { test } from "./main.js"; | ||
|
|
||
| // Verify `main` successfully obtains a token when the `owner` input is not set, but the `repositories` input is set. | ||
| await test(() => { | ||
| delete process.env.INPUT_OWNER; | ||
| process.env.INPUT_REPOSITORIES = process.env.GITHUB_REPOSITORY; | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // @ts-check | ||
| import { test } from "./main.js"; | ||
|
|
||
| // Verify `main` successfully obtains a token when neither the `owner` nor `repositories` input is set. | ||
| await test((mockPool) => { | ||
| delete process.env.INPUT_OWNER; | ||
| delete process.env.INPUT_REPOSITORIES; | ||
|
|
||
| // Mock installation id request | ||
| const mockInstallationId = "123456"; | ||
| mockPool | ||
| .intercept({ | ||
| path: `/repos/${process.env.GITHUB_REPOSITORY}/installation`, | ||
| method: "GET", | ||
| headers: { | ||
| accept: "application/vnd.github.v3+json", | ||
| "user-agent": "actions/create-github-app-token", | ||
| // Intentionally omitting the `authorization` header, since JWT creation is not idempotent. | ||
| }, | ||
| }) | ||
| .reply( | ||
| 200, | ||
| { id: mockInstallationId }, | ||
| { headers: { "content-type": "application/json" } } | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| // Base for all `main` tests. | ||
| // @ts-check | ||
| import { MockAgent, setGlobalDispatcher } from "undici"; | ||
|
|
||
| export async function test(cb = (_mockPool) => {}) { | ||
| // Clear Actions environment variables that change `core`’s behavior | ||
| delete process.env.GITHUB_OUTPUT; | ||
| delete process.env.GITHUB_STATE; | ||
| // Set required environment variables and inputs | ||
| process.env.GITHUB_REPOSITORY_OWNER = "actions"; | ||
| process.env.GITHUB_REPOSITORY = "actions/create-github-app-token"; | ||
| // inputs are set as environment variables with the prefix INPUT_ | ||
| // https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#example-specifying-inputs | ||
| process.env.INPUT_APP_ID = "123456"; | ||
| process.env.INPUT_PRIVATE_KEY = `-----BEGIN RSA PRIVATE KEY----- | ||
| MIIEowIBAAKCAQEA280nfuUM9w00Ib9E2rvZJ6Qu3Ua3IqR34ZlK53vn/Iobn2EL | ||
| Z9puc5Q/nFBU15NKwHyQNb+OG2hTCkjd1Xi9XPzEOH1r42YQmTGq8YCkUSkk6KZA | ||
| 5dnhLwN9pFquT9fQgrf4r1D5GJj3rqvj8JDr1sBmunArqY5u4gziSrIohcjLIZV0 | ||
| cIMz/RUIMe/EAsNeiwzEteHAtf/WpMs+OfF94SIUrDlkPr0H0H3DER8l1HZAvE0e | ||
| eD3ZJ6njrF6UHQWDVrekSTB0clpVTTU9TMpe+gs2nnFww9G8As+WsW8xHVjVipJy | ||
| AwqBhiR+s7wlcbh2i0NQqt8GL9/jIFTmleiwsQIDAQABAoIBAHNyP8pgl/yyzKzk | ||
| /0871wUBMTQ7zji91dGCaFtJM0HrcDK4D/uOOPEv7nE1qDpKPLr5Me1pHUS7+NGw | ||
| EAPtlNhgUtew2JfppdIwyi5qeOPADoi7ud6AH8xHsxg+IMwC+JuP8WhzyUHoJj9y | ||
| PRi/pX94Mvy9qdE25HqKddjx1mLdaHhxqPkr16/em23uYZqm1lORsCPD3vTlthj7 | ||
| WiEbBSqmpYvjj8iFP4yFk2N+LvuWgSilRzq1Af3qE7PUp4xhjmcOPs78Sag1T7nl | ||
| ww/pgqCegISABHik7j++/5T+UlI5cLsyp/XENU9zAd4kCIczwNKpun2bn+djJdft | ||
| ravyX4ECgYEA+k2mHfi1zwKF3wT+cJbf30+uXrJczK2yZ33//4RKnhBaq7nSbQAI | ||
| nhWz2JESBK0TEo0+L7yYYq3HnT9vcES5R1NxzruH9wXgxssSx3JUj6w1raXYPh3B | ||
| +1XpYQsa6/bo2LmBELEx47F8FQbNgD5dmTJ4jBrf6MV4rRh9h6Bs7UkCgYEA4M3K | ||
| eAw52c2MNMIxH/LxdOQtEBq5GMu3AQC8I64DSSRrAoiypfEgyTV6S4gWJ5TKgYfD | ||
| zclnOVJF+tITe3neO9wHoZp8iCjCnoijcT6p2cJ4IaW68LEHPOokWBk0EpLjF4p2 | ||
| 7sFi9+lUpXYXfCN7aMJ77QpGzB7dNsBf0KUxMCkCgYEAjw/mjGbk82bLwUaHby6s | ||
| 0mQmk7V6WPpGZ+Sadx7TzzglutVAslA8nK5m1rdEBywtJINaMcqnhm8xEm15cj+1 | ||
| blEBUVnaQpQ3fyf+mcR9FIknPRL3X7l+b/sQowjH4GqFd6m/XR0KGMwO0a3Lsyry | ||
| MGeqgtmxdMe5S6YdyXEmERECgYAgQsgklDSVIh9Vzux31kh6auhgoEUh3tJDbZSS | ||
| Vj2YeIZ21aE1mTYISglj34K2aW7qSc56sMWEf18VkKJFHQccdgYOVfo7HAZZ8+fo | ||
| r4J2gqb0xTDfq7gLMNrIXc2QQM4gKbnJp60JQM3p9NmH8huavBZGvSvNzTwXyGG3 | ||
| so0tiQKBgGQXZaxaXhYUcxYHuCkQ3V4Vsj3ezlM92xXlP32SGFm3KgFhYy9kATxw | ||
| Cax1ytZzvlrKLQyQFVK1COs2rHt7W4cJ7op7C8zXfsigXCiejnS664oAuX8sQZID | ||
| x3WQZRiXlWejSMUAHuMwXrhGlltF3lw83+xAjnqsVp75kGS6OH61 | ||
| -----END RSA PRIVATE KEY-----`; // This key is invalidated. It’s from https://github.com/octokit/auth-app.js/issues/465#issuecomment-1564998327. | ||
|
|
||
| // Set up mocking | ||
| const mockAgent = new MockAgent(); | ||
| mockAgent.disableNetConnect(); | ||
| setGlobalDispatcher(mockAgent); | ||
| const mockPool = mockAgent.get("https://api.github.com"); | ||
|
|
||
| // Calling `auth({ type: "app" })` to obtain a JWT doesn’t make network requests, so no need to intercept. | ||
|
|
||
| // Mock installation id request | ||
| const mockInstallationId = "123456"; | ||
| const owner = process.env.INPUT_OWNER ?? process.env.GITHUB_REPOSITORY_OWNER; | ||
| const repo = encodeURIComponent( | ||
| (process.env.INPUT_REPOSITORIES ?? process.env.GITHUB_REPOSITORY).split( | ||
| "," | ||
| )[0] | ||
| ); | ||
| mockPool | ||
| .intercept({ | ||
| path: `/repos/${owner}/${repo}/installation`, | ||
| method: "GET", | ||
| headers: { | ||
| accept: "application/vnd.github.v3+json", | ||
| "user-agent": "actions/create-github-app-token", | ||
| // Intentionally omitting the `authorization` header, since JWT creation is not idempotent. | ||
| }, | ||
| }) | ||
| .reply( | ||
| 200, | ||
| { id: mockInstallationId }, | ||
| { headers: { "content-type": "application/json" } } | ||
| ); | ||
|
|
||
| // Mock installation access token request | ||
| const mockInstallationAccessToken = | ||
| "ghs_16C7e42F292c6912E7710c838347Ae178B4a"; // This token is invalidated. It’s from https://docs.github.com/en/rest/apps/apps?apiVersion=2022-11-28#create-an-installation-access-token-for-an-app. | ||
| mockPool | ||
| .intercept({ | ||
| path: `/app/installations/${mockInstallationId}/access_tokens`, | ||
| method: "POST", | ||
| headers: { | ||
| accept: "application/vnd.github.v3+json", | ||
| "user-agent": "actions/create-github-app-token", | ||
| // Note: Intentionally omitting the `authorization` header, since JWT creation is not idempotent. | ||
| }, | ||
| }) | ||
| .reply( | ||
| 201, | ||
| { token: mockInstallationAccessToken }, | ||
| { headers: { "content-type": "application/json" } } | ||
| ); | ||
|
|
||
| // Run the callback | ||
| cb(mockPool); | ||
|
|
||
| // Run the main script | ||
| await import("../main.js"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.