Skip to content

Conversation

@Reinis-FRP
Copy link
Contributor

This PR demonstrates its possible to support native token deposits on solana with the current program implementation by prepending transfer/wrapping instructions to the deposit transaction.

Signed-off-by: Reinis Martinsons <[email protected]>
);

// Define the route account PDA
const [routePda] = PublicKey.findProgramAddressSync(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need to remove this once #939 is merged.

@mrice32 mrice32 changed the base branch from master to solana-march-audit-2 April 1, 2025 03:07
Copy link
Member

@chrismaree chrismaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! If we order the prs correctly you can delete the route pda logic after rebasing so we can have it match real world context.

@Reinis-FRP Reinis-FRP merged commit 71e990b into solana-march-audit-2 Apr 3, 2025
9 checks passed
@Reinis-FRP Reinis-FRP deleted the reinis-frp/native-sol-deposit branch April 3, 2025 07:25
Reinis-FRP added a commit that referenced this pull request May 21, 2025
* feat(svm): remove enabled deposit route check (#939)

* feat(svm): remove enabled deposit route check

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: remove create_vault ix

Signed-off-by: Reinis Martinsons <[email protected]>

* Update scripts/svm/simpleDeposit.ts

Co-authored-by: Chris Maree <[email protected]>

* fix: update comment

Signed-off-by: Reinis Martinsons <[email protected]>

---------

Signed-off-by: Reinis Martinsons <[email protected]>
Co-authored-by: Chris Maree <[email protected]>

* feat(svm): test native sol deposits (#942)

* feat(svm): test native sol deposits

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: merge issues

Signed-off-by: Reinis Martinsons <[email protected]>

---------

Signed-off-by: Reinis Martinsons <[email protected]>

* fix(svm): pin rust toolchain for solana (#960) (#961)

* fix(svm): pin rust toolchain for solana



* fix: add local toolchain



* fix: add rustfmt to nightly



* fix: pin nightly in lint scripts



---------

Signed-off-by: Reinis Martinsons <[email protected]>

* fix(svm): M-01 Deposit Tokens Transferred from Depositor Token Account Instead of Signer (#971)

* fix(svm): M-01 Deposit Tokens Transfers

Signed-off-by: Pablo Maldonado <[email protected]>

* feat: use unchecked account

Signed-off-by: Pablo Maldonado <[email protected]>

* feat: remove system acc

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: deposit tests

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: fill tests

Signed-off-by: Pablo Maldonado <[email protected]>

* refactor: rename and comments

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: across plus

Signed-off-by: Pablo Maldonado <[email protected]>

* fix(svm): pin rust toolchain for solana (#960)

* fix(svm): pin rust toolchain for solana

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: add local toolchain

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: add rustfmt to nightly

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: pin nightly in lint scripts

Signed-off-by: Reinis Martinsons <[email protected]>

---------

Signed-off-by: Reinis Martinsons <[email protected]>

* refactor: rename and organize function

Signed-off-by: Pablo Maldonado <[email protected]>

* feat: update deposit delegate seed

Signed-off-by: Pablo Maldonado <[email protected]>

* feat: use relay_hash from function arguments

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: heap memory error

Signed-off-by: Pablo Maldonado <[email protected]>

* fix

Signed-off-by: Pablo Maldonado <[email protected]>

* refactor: cleanup

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: deposit checks

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: fill tests

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: fill relay delagate

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: fill

Signed-off-by: Pablo Maldonado <[email protected]>

* refactor: simplify

Signed-off-by: Pablo Maldonado <[email protected]>

* refactor: cleanup

Signed-off-by: Pablo Maldonado <[email protected]>

* test: update fill tests

Signed-off-by: Pablo Maldonado <[email protected]>

* refactor: comments

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: scripts

Signed-off-by: Pablo Maldonado <[email protected]>

* refactor: make seed structs private

Signed-off-by: Pablo Maldonado <[email protected]>

* feat: add missing params to deposit hashes

Signed-off-by: Pablo Maldonado <[email protected]>

* refactor: simplify

Signed-off-by: Pablo Maldonado <[email protected]>

* refactor: delegate utils

Signed-off-by: Pablo Maldonado <[email protected]>

* refactor: anchor serialize

Signed-off-by: Pablo Maldonado <[email protected]>

* refactor: reuse helper deriveSeedHash

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: move paused fills check in handler

Signed-off-by: Reinis Martinsons <[email protected]>

* feat: improvements

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: remove program_id from transfer_from params

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: fill import

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: tests

Signed-off-by: Pablo Maldonado <[email protected]>

---------

Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Co-authored-by: Reinis Martinsons <[email protected]>
Co-authored-by: Reinis Martinsons <[email protected]>

* fix(svm): N-01 remove v3 from remaining functions and comments (#964)

Signed-off-by: Reinis Martinsons <[email protected]>

* fix(svm): L-01 create new vault on deposit if needed (#957)

* fix(svm): L-01 create new vault on deposit if needed

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: use stable toolchain in ci

Signed-off-by: Reinis Martinsons <[email protected]>

* fix(svm): pin rust toolchain for solana (#960)

* fix(svm): pin rust toolchain for solana

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: add local toolchain

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: add rustfmt to nightly

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: pin nightly in lint scripts

Signed-off-by: Reinis Martinsons <[email protected]>

---------

Signed-off-by: Reinis Martinsons <[email protected]>

---------

Signed-off-by: Reinis Martinsons <[email protected]>

* fix(svm): N-02 clarify documentation (#963)

Signed-off-by: Reinis Martinsons <[email protected]>

* fix(svm): N-03 use consistent variable names in the instruction constraint (#962)

* fix(svm): pin rust toolchain for solana (#960)

* fix(svm): pin rust toolchain for solana

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: add local toolchain

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: add rustfmt to nightly

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: pin nightly in lint scripts

Signed-off-by: Reinis Martinsons <[email protected]>

---------

Signed-off-by: Reinis Martinsons <[email protected]>

* fix(svm): N-03 use consistent variable names in the instruction constraint

Signed-off-by: Reinis Martinsons <[email protected]>

* fix: restore relay_hash naming in FillRelay context

Signed-off-by: Reinis Martinsons <[email protected]>

---------

Signed-off-by: Reinis Martinsons <[email protected]>

* feat: update toolchain

Signed-off-by: Pablo Maldonado <[email protected]>

* feat: update toolchain bis

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: delete old scripts

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: across plus codama test

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: fill test codama

Signed-off-by: Pablo Maldonado <[email protected]>

* feat: bump version

Signed-off-by: Pablo Maldonado <[email protected]>

* fix: bump version

Signed-off-by: Reinis Martinsons <[email protected]>

---------

Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
Co-authored-by: Reinis Martinsons <[email protected]>
Co-authored-by: Chris Maree <[email protected]>
Co-authored-by: Reinis Martinsons <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants