proposal: refine how we define PDA paths for some account types #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismaree <[email protected]>
Signed-off-by: chrismaree <[email protected]>
Signed-off-by: chrismaree <[email protected]>
Signed-off-by: chrismaree <[email protected]>
Reinis-FRP
approved these changes
Nov 21, 2024
Contributor
Reinis-FRP
left a comment
Reinis-FRP
left a comment
There was a problem hiding this comment.
Using state.seed seems more consistent. though there are some comments we delete that are not yet addressed.
| pub refund_address: Pubkey, | ||
| } | ||
|
|
||
| // TODO: update the name of this to EmergencyDeletedRootBundle and in EVM. |
Contributor
There was a problem hiding this comment.
we have not fixed this in EVM
| State, | ||
| }; | ||
|
|
||
| //TODO: we have inconsistent imports in this file, in some places referencing from source crates (SvmSpoke::id) |
Contributor
There was a problem hiding this comment.
we have not addressed this
Member
Author
There was a problem hiding this comment.
right but the thing it was referencing for some reason could not be refactored like other imports.
| pub remote_domain: u32, // CCTP domain for Mainnet Ethereum. | ||
| pub cross_domain_admin: Pubkey, // HubPool on Mainnet Ethereum. | ||
| pub root_bundle_id: u32, // TODO rename to next_root_bundle_id | ||
| pub root_bundle_id: u32, // Tracks the current root bundle id. |
Contributor
There was a problem hiding this comment.
but it is not the current root bundle id. It is next one, thus we had comment to rename this prop
Member
Author
There was a problem hiding this comment.
I chose to just update the comment accordingly.
Signed-off-by: chrismaree <[email protected]>
Signed-off-by: chrismaree <[email protected]>
Signed-off-by: chrismaree <[email protected]>
Signed-off-by: chrismaree <[email protected]>
Signed-off-by: chrismaree <[email protected]>
Signed-off-by: chrismaree <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR refines how we define PDAs in some places to make them more consistently dependent on the seed, rather than state