-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Allow renew time relative to the expiration date #4457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
I do not think, the error of the pipeline is related to the pull request. |
5dda252 to
b84acb6
Compare
You can now set a negative value for days, that will be subtracted from the expiration date of the generated certificate.
b84acb6 to
4d9d59a
Compare
|
Any update on this PR? |
|
??? Nothing? |
|
Unfortunately, there has been no response to the pull request yet. We've been using this change in production for a long time, and it works very well. Given the different expiration times for server certificates at different CAs, this is very helpful, and the expiration times will continue to change in the future, so this change is very important for automation. |
|
Looks like someone else needs to take over this project, acmesh-official is not doing anything for pull requests. |
|
Ultimately #4944 ARI support is going to fulfill this need in most cases, I can see that the work has already began. The change in this PR would still be useful nonetheless of course. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please approve the PR for relative expiry date.
You can now set a negative value for days, that will be subtracted from the expiration date of the generated certificate.
This will fix #3413.