Skip to content

Conversation

@achim-k
Copy link
Owner

@achim-k achim-k commented Apr 10, 2023

Builds on top of ros2#1052

Adds latest commits from ros2/rcl:rolling which are missing in the the original PR

emersonknapp and others added 3 commits April 10, 2023 12:22
* Get discovery preferences from the environment

Signed-off-by: Geoffrey Biggs <[email protected]>

* Support specification of discovery range and static peers

Signed-off-by: Geoffrey Biggs <[email protected]>

* Add some debug helpers

Signed-off-by: Geoffrey Biggs <[email protected]>

* Cleanup the LOCALHOST_ONLY deprecation a bit.

Only print out the warning if it is actually specified.

Signed-off-by: Chris Lalancette <[email protected]>

* Rewrite parsing of static peers.

Mostly to get rid of the use of strtok_r, which is dangerous
and also should not be used on our static environment variables.
Instead, use rcutils_split(), which is much better.

Signed-off-by: Chris Lalancette <[email protected]>

* Fix some silly bugs.

Signed-off-by: Chris Lalancette <[email protected]>

* Use names instead of integers for discovery range env vars

Signed-off-by: Michael X. Grey <[email protected]>

* Add support for dynamic allocation

This commit adds support for dynamic allocation for unlimited number of
static peers.

Signed-off-by: Arjo Chakravarty <[email protected]>

* Add a warning if ROS_AUTOMATIC_DISCOVERY_OFF is set and STATIC_PEERS are
set.

Signed-off-by: Arjo Chakravarty <[email protected]>

* Update to latest rmw API

Signed-off-by: Michael X. Grey <[email protected]>

* Uncrustify

Signed-off-by: Michael X. Grey <[email protected]>

* Update for rmw_discovery_options_t changes

Signed-off-by: Shane Loretz <[email protected]>

* Address feedback: use strncmp

Signed-off-by: Arjo Chakravarty <[email protected]>

* Address feedback: Log levels

Signed-off-by: Arjo Chakravarty <[email protected]>

* Address feedback: remove TODO

Signed-off-by: Arjo Chakravarty <[email protected]>

* Address feedback: rename function

Signed-off-by: Arjo Chakravarty <[email protected]>

* ddress feedback: Docstring

Signed-off-by: Arjo Chakravarty <[email protected]>

* Address feedback: comment

Signed-off-by: Arjo Chakravarty <[email protected]>

* Add `RCL_RET_ERROR` if fini fails.

Signed-off-by: Arjo Chakravarty <[email protected]>

* `snprintf`->`rcutils_snprintf`

Signed-off-by: Arjo Chakravarty <[email protected]>

* Rename tests

Signed-off-by: Arjo Chakravarty <[email protected]>

* rcl_get_discovery_automatic_range -> rcl_get_automatic_discovery_range in test

Signed-off-by: Shane Loretz <[email protected]>

* Annotate tests

Signed-off-by: Arjo Chakravarty <[email protected]>

* More comments

Signed-off-by: Arjo Chakravarty <[email protected]>

* Style

Signed-off-by: Arjo Chakravarty <[email protected]>

* Style

Signed-off-by: Arjo Chakravarty <[email protected]>

* Uncrustify

Signed-off-by: Arjo Chakravarty <[email protected]>

* Constness and warning

Signed-off-by: Arjo Chakravarty <[email protected]>

* address TODO about IP address validation in the static peers

Signed-off-by: William Woodall <[email protected]>

* NOT_SET and SYSTEM_DEFAULT values

Signed-off-by: Shane Loretz <[email protected]>

* refactor discovery options to handle env vars better and simplify stringifying enums

Signed-off-by: William Woodall <[email protected]>

* fixup docs

Signed-off-by: William Woodall <[email protected]>

* (re)improve the discovery range debug message

Signed-off-by: William Woodall <[email protected]>

* Set discovery options to NOT_SET to detect user changse

Signed-off-by: Shane Loretz <[email protected]>

* lint

Signed-off-by: Shane Loretz <[email protected]>

* strncpy_s on windows

Signed-off-by: Shane Loretz <[email protected]>

* Change default range to SUBNET, and allow configuring it at build time

Signed-off-by: Shane Loretz <[email protected]>

---------

Signed-off-by: Geoffrey Biggs <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: William Woodall <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Michael X. Grey <[email protected]>
Co-authored-by: Arjo Chakravarty <[email protected]>
Co-authored-by: Shane Loretz <[email protected]>
Co-authored-by: William Woodall <[email protected]>
* Implement runtime type typesupport struct

Signed-off-by: methylDragon <[email protected]>

* Implement first cut

Signed-off-by: methylDragon <[email protected]>

* Migrate to rosidl_dynamic_typesupport and update field IDs

Signed-off-by: methylDragon <[email protected]>

* Migrate to type description interfaces

Signed-off-by: methylDragon <[email protected]>

* Fix const

Signed-off-by: methylDragon <[email protected]>

* Refine signatures and use return types

Signed-off-by: methylDragon <[email protected]>

* Fix C linkage

Signed-off-by: methylDragon <[email protected]>

* Migrate methods to use return types

Signed-off-by: methylDragon <[email protected]>

* Lint

Signed-off-by: methylDragon <[email protected]>

* Support type hashes

Signed-off-by: methylDragon <[email protected]>

* Remove identifier alias

Signed-off-by: methylDragon <[email protected]>

* Change fini to destroy

Signed-off-by: methylDragon <[email protected]>

* Use create instead of init

Signed-off-by: methylDragon <[email protected]>

* Add rcutils conversion function and remove rmw interfaces

Signed-off-by: methylDragon <[email protected]>

* Clean up some comments

Signed-off-by: methylDragon <[email protected]>

---------

Signed-off-by: methylDragon <[email protected]>
@achim-k achim-k merged commit 9a0f81b into achim-k/rep2011_get_type_description_srv Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants