feat: add --ky option #690
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
force-pushed
the
feat/ky-client
branch
3 times, most recently
from
e42d28c to
8be147d
Compare
Generate a client that uses this library: https://github.com/sindresorhus/ky
aleclarson
force-pushed
the
feat/ky-client
branch
from
8be147d to
7c8567e
Compare
Since ky has a special ResponsePromise type, the `request` method cannot use async-await syntax and the returned promise must come from ky (so the expected methods are there). This means the securityWorker cannot be supported by the ky client.
aleclarson
force-pushed
the
feat/ky-client
branch
from
3d7ae28 to
5ed1fe4
Compare
aleclarson
force-pushed
the
feat/ky-client
branch
2 times, most recently
from
bf2adbb to
04b800b
Compare
aleclarson
force-pushed
the
feat/ky-client
branch
from
04b800b to
8c770b8
Compare
|
If anyone is interested in using or testing this, it's published to NPM under /cc @hardouinyann @AshotN (since you both reacted) |
There was a problem hiding this comment.
Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- package.json: Language not supported
- templates/base/http-clients/ky-http-client.ejs: Language not supported
- templates/default/procedure-call.ejs: Language not supported
- templates/modular/procedure-call.ejs: Language not supported
Co-authored-by: Copilot <[email protected]>
|
Is this PR still relevant ? We would love to use ky in particular with the built-in retry mechanism |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a client that uses this library: https://github.com/sindresorhus/ky