Skip to content

fix: handle arrays properly in FormData #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: handle arrays properly in FormData #1431

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1b22ef
fix: handle arrays properly in FormData
omarmciver Sep 23, 2025
e4c4bae
fix: apply formatter to test fixture
omarmciver Sep 23, 2025
b9da1cd
refactor: simplify FormData type checking and fix string handling
omarmciver Oct 14, 2025
6e854b8
test: update snapshots for FormData refactoring
omarmciver Oct 14, 2025
abc99ef
Update templates/base/http-clients/fetch-http-client.ejs
omarmciver Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions templates/base/http-clients/fetch-http-client.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,11 @@ export class HttpClient<SecurityDataType = unknown> {

return Object.keys(input || {}).reduce((formData, key) => {
const property = input[key];
formData.append(
key,
property instanceof Blob ?
property :
typeof property === "object" && property !== null ?
JSON.stringify(property) :
`${property}`
);
const propertyContent = property instanceof Array ? property : [property];

for (const formItem of propertyContent) {
formData.append(key, formItem instanceof Blob || typeof formItem === "string" ? formItem : JSON.stringify(formItem));
Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition formItem instanceof Blob || typeof formItem === 'string' does not handle File objects correctly. File extends Blob, but numbers, booleans, and other primitive types will be JSON.stringify'd instead of being converted to strings. This changes behavior from the original code which used template literal coercion (${property}) for primitives.

Suggested change
formData.append(key, formItem instanceof Blob || typeof formItem === "string" ? formItem : JSON.stringify(formItem));
formData.append(key, formItem instanceof Blob ? formItem : `${formItem}`);

Copilot uses AI. Check for mistakes.
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: FormData Serialization Fails with BigInt and Undefined

The FormData serialization logic now uses JSON.stringify for non-Blob/non-string values, which introduces two issues. BigInt values now cause a TypeError. Also, undefined values are passed as the undefined primitive to formData.append(), relying on implicit browser conversion instead of the previous explicit string conversion, which may lead to unexpected behavior.

Fix in Cursor Fix in Web

return formData;
}, new FormData());
},
Expand Down
Loading