Skip to content

Conversation

GregHolmes
Copy link
Contributor

Description

This PR converts the Realtime SDK Statistics API reference page from Textile format to MDX, as part of a full textile to MDX migration.

@GregHolmes GregHolmes self-assigned this Oct 9, 2025
@GregHolmes GregHolmes added the review-app Create a Heroku review app label Oct 9, 2025
@ably-ci ably-ci temporarily deployed to ably-docs-edu-2046-conv-rgoief October 9, 2025 12:03 Inactive
Copy link

coderabbitai bot commented Oct 9, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch EDU-2046-Convert-Pub-Sub-JavaScript-API-refs-to-MDX

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@m-hulbert m-hulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are going to be painful to review, but thanks for getting the ball rolling!


<If lang="javascript,nodejs,java,csharp">

| Parameter | Type | Description |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should all have the order changed to:

Paramater | Description | Type | Default |

We may even want to role the default into the description if it saves room / is simple.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the first table needs a default. But I've rearranged all of this for the second table.

@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2046-conv-rgoief October 10, 2025 09:22 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2046-conv-rgoief October 13, 2025 08:35 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2046-conv-rgoief October 13, 2025 08:37 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2046-conv-rgoief October 13, 2025 08:37 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2046-conv-rgoief October 13, 2025 09:25 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2046-conv-rgoief October 13, 2025 09:29 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2046-conv-rgoief October 13, 2025 11:38 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2046-conv-rgoief October 13, 2025 12:35 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2046-conv-rgoief October 13, 2025 12:38 Inactive

<If lang="ruby">

| Parameter | Type | Description |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant that I think all tables should always be Param | Description | Type - looking at this as well, I think the default (if exists) should just go at the end of the description. E.g.:

| start | Earliest time in milliseconds since the epoch for any stats retrieved. The default is the beginning of time. | `Number` |

- /docs/api/versions/v0.8/realtime-sdk/statistics
---

## stats <a id="stats" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this page was missing a header for 'Methods' compared to the others. I think this will make things look less huge if we add that in and drop the level of everything else below it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

3 participants