-
Notifications
You must be signed in to change notification settings - Fork 63
Improve error messages for better user experience #2075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit updates error message strings to be more descriptive and user-friendly, providing clearer guidance on what went wrong and how to resolve issues. Changes include: src/common/lib/client/auth.ts | 3 ++- src/common/lib/client/baseclient.ts | 3 ++- src/common/lib/client/realtimechannel.ts | 3 ++- src/common/lib/client/realtimepresence.ts | 6 ++++-- src/common/lib/client/rest.ts | 6 ++++-- src/common/lib/transport/connectionmanager.ts | 3 ++- src/common/lib/transport/transport.ts | 3 ++- src/common/lib/types/basemessage.ts | 3 ++- src/common/types/http.ts | 6 ++++-- src/platform/nodejs/lib/util/crypto.ts | 3 ++- src/platform/web/lib/util/crypto.ts | 3 ++- src/plugins/objects/batchcontextlivecounter.ts | 5 +++-- src/plugins/objects/objectid.ts | 3 ++- 13 files changed, 33 insertions(+), 17 deletions(-) These improvements are part of an ongoing initiative to enhance error messaging across all Ably SDKs and services for better developer experience. For more context, see: https://github.com/ably/ably-os
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Appreciate this is a PoC so not reviewing this from the point of view of merging, but just how we should improve ably-os (which I assume will fall to ecosystems!):
Other than that, the changes seem reasonable. |
Summary
This PR improves error messages throughout the codebase to be more descriptive and user-friendly, providing clearer guidance on what went wrong and how to resolve issues.
Changes
This commit updates error message strings to be more descriptive and user-friendly,
providing clearer guidance on what went wrong and how to resolve issues.
Changes include:
src/common/lib/client/auth.ts | 3 ++-
src/common/lib/client/baseclient.ts | 3 ++-
src/common/lib/client/realtimechannel.ts | 3 ++-
src/common/lib/client/realtimepresence.ts | 6 ++++--
src/common/lib/client/rest.ts | 6 ++++--
src/common/lib/transport/connectionmanager.ts | 3 ++-
src/common/lib/transport/transport.ts | 3 ++-
src/common/lib/types/basemessage.ts | 3 ++-
src/common/types/http.ts | 6 ++++--
src/platform/nodejs/lib/util/crypto.ts | 3 ++-
src/platform/web/lib/util/crypto.ts | 3 ++-
src/plugins/objects/batchcontextlivecounter.ts | 5 +++--
src/plugins/objects/objectid.ts | 3 ++-
13 files changed, 33 insertions(+), 17 deletions(-)
Benefits
Testing
This improvement is part of an ongoing initiative to enhance error messaging across all Ably SDKs and services.
Repository Context
This repository is part of Ably's ecosystem. Here's context about all repositories:
For more context, see: https://github.com/ably/ably-os