k3s: retry ip address retrieval during setup #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When networking is enabled but the interface does not have any IP assigned yet, k3s installation can fail. This changes that to wait for up to 20 seconds for an address to be assigned before failing. Fixes abiosoft#1373
Nevon
commented
Aug 7, 2025
|
Looks like one of the runners had an issue for one of the checks, but I don't have a way to retrigger it. |
abiosoft
reviewed
Aug 7, 2025
Co-authored-by: Abiola Ibrahim <[email protected]>
abiosoft
approved these changes
Aug 7, 2025
abiosoft
changed the title
|
Thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When networking is enabled but the interface does not have any IP assigned yet, k3s installation can fail. The
IPAddressfunction says that it is guaranteed to return a value, which is technically true, but that value can be an empty string if the network interface exists but doesn't have any IP assigned.This changes the k3s installation to wait for up to 20 seconds for an address to be assigned before failing.
Fixes #1373