Skip to content

k3s: allow overriding default k3s args #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025

Conversation

Nevon
Copy link
Contributor

@Nevon Nevon commented Aug 5, 2025

Fixes #1363 and relates to #1362.

I went through all the arguments being passed by Colima to k3s to see which ones seemed reasonable to be able to override, and only found these two. Before this change, passing --k3s-arg="--advertise-address=127.0.0.2" would just add that argument so that the actual parameters to k3s would be something like --advertise-address=127.0.0.2 --advertise-address=192.168.0.5, with the latter one being set by Colima.

@abiosoft abiosoft changed the title Allow overriding k3s args k3s: allow overriding default k3s args Aug 5, 2025
Co-authored-by: Abiola Ibrahim <[email protected]>
@abiosoft abiosoft merged commit 4cb3aa9 into abiosoft:main Aug 5, 2025
11 checks passed
@abiosoft
Copy link
Owner

abiosoft commented Aug 5, 2025

Thanks :)

@Nevon Nevon deleted the allow-override-k3s-arg branch August 5, 2025 13:29
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 6, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [abiosoft/colima](https://github.com/abiosoft/colima) | patch | `v0.8.2` -> `v0.8.3` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>abiosoft/colima (abiosoft/colima)</summary>

### [`v0.8.3`](https://github.com/abiosoft/colima/releases/tag/v0.8.3)

[Compare Source](abiosoft/colima@v0.8.2...v0.8.3)

#### Highlights

This is an hotfix release to address a regression that causes `exec /bin/sh: exec format error` when running a cross-architecture image.

#### Fixes

- Fix exec format error when running a cross-architecture image. Requires recreating instance if created with v0.8.2. Fixes [#&#8203;1367](abiosoft/colima#1367).
- Set default volume mount type to `virtiofs` when VZ is in use.

#### Other Updates

- Use containerd image store for Docker
- Mount containerd socket for Docker and Containerd runtimes
- Mount buildkitd socket for Containerd runtime.
- Add mounted socket path(s) to the output of `colima status` for all container runtimes.
- Allow overriding default k3s flags with `--k3s-arg` flag.

#### Commits

- Potential fix for code scanning alert no. 7: Incorrect conversion between integer types by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1357
- containerd: expose containerd and buildkit sockets by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1358
- cli: set default mount type to virtiofs for vz by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1359
- Docker improvements by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1360
- k3s: allow overriding default k3s args by [@&#8203;Nevon](https://github.com/Nevon) in abiosoft/colima#1365
- core: update disk images by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1368

#### New Contributors

- [@&#8203;Nevon](https://github.com/Nevon) made their first contribution in abiosoft/colima#1365

**Full Changelog**: abiosoft/colima@v0.8.2...v0.8.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS41Mi4yIiwidXBkYXRlZEluVmVyIjoiNDEuNTIuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot override k3s arguments during cluster installation
2 participants