Skip to content

k3s: fix config defaults for Kubernetes values #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

kaisq
Copy link
Contributor

@kaisq kaisq commented May 13, 2025

Only use values from the config file for Kuberentes.Version and K3sArgs if the values are actually set.

Fixes #1012

@kaisq kaisq force-pushed the fix-k3s-defaults branch from 4afaac2 to c1ca207 Compare May 13, 2025 18:37
@abiosoft abiosoft changed the title Fix config defaults for Kubernetes values k3s: fix config defaults for Kubernetes values Jul 31, 2025
@abiosoft abiosoft merged commit 338b20b into abiosoft:main Jul 31, 2025
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Aug 1, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [abiosoft/colima](https://github.com/abiosoft/colima) | patch | `v0.8.1` -> `v0.8.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>abiosoft/colima (abiosoft/colima)</summary>

### [`v0.8.2`](https://github.com/abiosoft/colima/releases/tag/v0.8.2)

[Compare Source](abiosoft/colima@v0.8.1...v0.8.2)

#### Highlights

This is an incremental release with bug fixes.

#### Fixes

- Report errors that occur while reading configuration file. Fixes [#&#8203;1239](abiosoft/colima#1239).
- Use native shasum binary for download assets verification. Fixes [#&#8203;1163](abiosoft/colima#1163).
- Fix download errors when K3s version when empty in config.
- Reset formatting after questions prompts in the terminal. Fixes [#&#8203;1319](abiosoft/colima#1319).

#### Other Updates

- UDP port forwarding is now supported. Resolves [#&#8203;1292](abiosoft/colima#1292), [#&#8203;1300](abiosoft/colima#1300).
- Binfmt emulation is configurable via the `--binfmt` flag and `binfmt` config. Defaults to `true` when Rosetta is disabled.
- Rename `--cpu` flag to `--cpus` for `colima start`, to align with Lima. `--cpu` still works but deprecated.
- Current profile can now be set with `COLIMA_PROFILE` environment variable. Resolves [#&#8203;1308](abiosoft/colima#1308).

##### Runtime version bumps

**NOTE:** container runtime versions can be updated manually by running the `colima update` command.

- Docker version updated to `v28.3.3`
- Nerdctl version updated to `v2.1.3`
- Incus version updated to `v6.14`
- K3s version defaults to `v1.33.3+k3s1 `

#### Commits

- ci: enable gocritic in golangci by [@&#8203;PascalBourdier](https://github.com/PascalBourdier) in abiosoft/colima#1223
- faq: update to address potential need for Docker client configuration by [@&#8203;carljmosca](https://github.com/carljmosca) in abiosoft/colima#1231
- cli: add quotes to k3s-arg example for colima start by [@&#8203;olamilekan000](https://github.com/olamilekan000) in abiosoft/colima#1230
- chore: update LICENSE, fix copyright license year by [@&#8203;JasonnnW3000](https://github.com/JasonnnW3000) in abiosoft/colima#1235
- chore: fix copyright license year (Revert [#&#8203;1235](abiosoft/colima#1235)) by [@&#8203;windyakin](https://github.com/windyakin) in abiosoft/colima#1237
- chore: log possible error while reading config file by [@&#8203;olamilekan000](https://github.com/olamilekan000) in abiosoft/colima#1240
- build(deps): bump golang.org/x/term from 0.27.0 to 0.28.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in abiosoft/colima#1242
- core: use native shasum binary on macOS for download verification by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1245
- core: config initial value for kubernetes version if empty in yaml by [@&#8203;jason19970210](https://github.com/jason19970210) in abiosoft/colima#1255
- k8s: update latest version for default kubernetes release by [@&#8203;jason19970210](https://github.com/jason19970210) in abiosoft/colima#1259
- core: respect LIMA\_SSH\_PORT\_FORWARDER env var by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1263
- build(deps): bump golang.org/x/term from 0.28.0 to 0.29.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in abiosoft/colima#1268
- incus: remove core.https\_address from default config by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1273
- build(deps): bump github.com/spf13/cobra from 1.8.1 to 1.9.1 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in abiosoft/colima#1274
- docker: fix cgroupdriver by [@&#8203;win-t](https://github.com/win-t) in abiosoft/colima#1312
- revert: "docker: fix cgroupdriver" by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1314
- Properly reset formatting at the end of question prompts by [@&#8203;SukritBhatt](https://github.com/SukritBhatt) in abiosoft/colima#1324
- chore: reorganize dependencies in go.mod by [@&#8203;alexandear](https://github.com/alexandear) in abiosoft/colima#1325
- github workflows: pin dependencies by [@&#8203;thypon](https://github.com/thypon) in abiosoft/colima#1326
- vm: support UDP port forwarding by [@&#8203;stek29](https://github.com/stek29) in abiosoft/colima#1343
- core: update disk images by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1351
- k3s: fix config defaults for Kubernetes values by [@&#8203;kaisq](https://github.com/kaisq) in abiosoft/colima#1322
- vm: make binfmt emulation configurable by [@&#8203;winterqt](https://github.com/winterqt) in abiosoft/colima#1315
- docker: replace also localhost with host gateway ip in docker daemon.json by [@&#8203;fralken](https://github.com/fralken) in abiosoft/colima#1298
- k3s: write kubeconfig to KUBECONFIG defined file by [@&#8203;Sumoa](https://github.com/Sumoa) in abiosoft/colima#978
- Multiple minor updates by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1352
- build(deps): bump golang.org/x/term from 0.29.0 to 0.30.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in abiosoft/colima#1281
- chore: expend the path information about current profile being used by [@&#8203;jason19970210](https://github.com/jason19970210) in abiosoft/colima#1270
- core: add support for COLIMA\_PROFILE environment variable. by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1353
- ci: bump Go version by [@&#8203;abiosoft](https://github.com/abiosoft) in abiosoft/colima#1354

#### New Contributors

- [@&#8203;PascalBourdier](https://github.com/PascalBourdier) made their first contribution in abiosoft/colima#1223
- [@&#8203;carljmosca](https://github.com/carljmosca) made their first contribution in abiosoft/colima#1231
- [@&#8203;olamilekan000](https://github.com/olamilekan000) made their first contribution in abiosoft/colima#1230
- [@&#8203;JasonnnW3000](https://github.com/JasonnnW3000) made their first contribution in abiosoft/colima#1235
- [@&#8203;windyakin](https://github.com/windyakin) made their first contribution in abiosoft/colima#1237
- [@&#8203;jason19970210](https://github.com/jason19970210) made their first contribution in abiosoft/colima#1255
- [@&#8203;win-t](https://github.com/win-t) made their first contribution in abiosoft/colima#1312
- [@&#8203;SukritBhatt](https://github.com/SukritBhatt) made their first contribution in abiosoft/colima#1324
- [@&#8203;alexandear](https://github.com/alexandear) made their first contribution in abiosoft/colima#1325
- [@&#8203;thypon](https://github.com/thypon) made their first contribution in abiosoft/colima#1326
- [@&#8203;stek29](https://github.com/stek29) made their first contribution in abiosoft/colima#1343
- [@&#8203;kaisq](https://github.com/kaisq) made their first contribution in abiosoft/colima#1322
- [@&#8203;winterqt](https://github.com/winterqt) made their first contribution in abiosoft/colima#1315
- [@&#8203;fralken](https://github.com/fralken) made their first contribution in abiosoft/colima#1298
- [@&#8203;Sumoa](https://github.com/Sumoa) made their first contribution in abiosoft/colima#978

**Full Changelog**: abiosoft/colima@v0.8.1...v0.8.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS40Ni4zIiwidXBkYXRlZEluVmVyIjoiNDEuNDYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error provisioning kubernetes: error at 'downloading and installing'
2 participants