Skip to content

Conversation

@bradegler
Copy link
Contributor

@bradegler bradegler commented Apr 29, 2025

Updates for linting changed the logic from [ "$checksum_file" = ""] which is true when there is no filename as the first argument to [[ -n "${checksum_file}" ]] which is true when there is a filename as the first argument. This is the reverse of the original logic and causes the script to always fail.

I changed the logic to be a test on the number of arguments instead of testing the length of a string in arg position 1. This will catch additional errors where callers may attempt to call this with extra arguments thinking that it can support multiple checksum files.

@bradegler bradegler requested a review from a team as a code owner April 29, 2025 14:36
@bradegler bradegler requested review from dcreey and ian-shafer April 29, 2025 14:36
@bradegler bradegler force-pushed the bradegler/still_fixing_gen_checksums branch from f2fee60 to 5f4bdbf Compare April 29, 2025 14:38
@bradegler bradegler merged commit 26706fb into main Apr 29, 2025
2 checks passed
@bradegler bradegler deleted the bradegler/still_fixing_gen_checksums branch April 29, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants