fix(platforminterop): Fix preprocessor directives for code inclusion #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates preprocessor directives to improve .NET Framework compatibility by replacing specific version targeting with broader framework targeting. The change ensures that the code properly compiles for all .NET Framework versions rather than being limited to version 4.7 specifically.
- Updated conditional compilation from version-specific
NET47to framework-generalNETFRAMEWORK - Ensured consistency between the two complementary files that use opposite preprocessor conditions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Yubico.Core/src/Yubico/PlatformInterop/Libraries.cs | Changed preprocessor directive from !NET47 to !NETFRAMEWORK for non-Framework builds |
| Yubico.Core/src/Yubico/PlatformInterop/Libraries.Net47.cs | Changed preprocessor directive from NET47 to NETFRAMEWORK for Framework builds |
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates preprocessor directives to use
NETFRAMEWORKinstead ofNET47for conditional compilation. This change helps ensure compatibility with all .NET Framework versions, not just 4.7.Platform compatibility updates:
NET47toNETFRAMEWORKinLibraries.Net47.csto generalize framework targeting.!NET47to!NETFRAMEWORKinLibraries.csfor consistency with the new directive.