Skip to content

fix: Correct logger for OtpSession #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

fix: Correct logger for OtpSession #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3557fcb
fix: Correct logger for OtpSession
DennisDyallo Jul 7, 2025
e956c1c
misc: Remove unused using statements
DennisDyallo Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Yubico.YubiKey/src/Yubico/YubiKey/Oath/OathSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@

using System;
using System.Globalization;
using Microsoft.Extensions.Logging;
using Yubico.Core.Logging;
using Yubico.YubiKey.InterIndustry.Commands;
using Yubico.YubiKey.Oath.Commands;
using Yubico.YubiKey.Scp;

Expand Down Expand Up @@ -83,7 +81,7 @@ public OathSession(IYubiKeyDevice yubiKey, ScpKeyParameters? keyParameters = nul
: base(Log.GetLogger<OathSession>(), yubiKey, YubiKeyApplication.Oath, keyParameters)
{

if (!(Connection.SelectApplicationData is OathApplicationData data))
if (Connection.SelectApplicationData is not OathApplicationData data)
{
throw new InvalidOperationException(nameof(Connection.SelectApplicationData));
}
Expand Down
2 changes: 1 addition & 1 deletion Yubico.YubiKey/src/Yubico/YubiKey/Otp/OtpSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public sealed class OtpSession : ApplicationSession, IOtpSession
/// <param name="keyParameters">An instance of <see cref="Scp03KeyParameters"/> containing the
/// parameters for the SCP03 key. If <see langword="null"/>, the default parameters will be used. </param>
public OtpSession(IYubiKeyDevice yubiKey, ScpKeyParameters? keyParameters = null)
: base(Log.GetLogger<OathSession>(), yubiKey, YubiKeyApplication.Otp, keyParameters)
: base(Log.GetLogger<OtpSession>(), yubiKey, YubiKeyApplication.Otp, keyParameters)
{
// Getting the OTP status allows the user to read the OTP status on the OtpSession object.
_otpStatus = Connection.SendCommand(new ReadStatusCommand()).GetData();
Expand Down
Loading