-
Notifications
You must be signed in to change notification settings - Fork 60
fix(macOS): Hard coding the default frameworks path in order to resolve macOS frameworks #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue with macOS framework resolution by updating framework path constants to use absolute paths.
- Updates the constants for CoreFoundation, IOKitFramework, and WinSCard in the macOS interop library.
Comments suppressed due to low confidence (1)
Yubico.Core/src/Yubico/PlatformInterop/macOS/Interop.Libraries.cs:19
- Consider adding an inline comment explaining why absolute paths are used here, including a reference to the runtime issue. This can help maintain clarity for future maintenance.
internal const string CoreFoundation = "/System/Library/Frameworks/CoreFoundation.framework/CoreFoundation";
|
@AdamVe Are you able to test this on NET6 and NET8 and confirm that it works? |
Test Results: Windows 2 files 2 suites 9s ⏱️ Results for commit 89d8e64. |
Test Results: Ubuntu 2 files 2 suites 21s ⏱️ Results for commit 89d8e64. |
Test Results: MacOS 2 files 2 suites 10s ⏱️ Results for commit 89d8e64. |
AdamVe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the integration tests run on mac without needing to setup any extra env variables.
Description
This pull request updates the
Librariesclass inYubico.Core/src/Yubico/PlatformInterop/macOS/Interop.Libraries.csto use absolute paths for macOS framework references. This change ensures compatibility with the system's directory structure.This is due to an ongoing issue at MSFT and dotnet, where the .NET runtime is no longer searching the correct framework paths since NET7. This fix works for NET6,7,8,9.
Updates to macOS framework paths:
CoreFoundation,IOKitFramework, andWinSCardconstants to use absolute paths (/System/Library/Frameworks/...) instead of relative paths (.framework/...) to align with macOS system conventions.Fixes: #205
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test configuration:
Checklist:
dotnet formatto format my codeFootnotes
See Yubikey models (Multi-protocol, Security Key, FIPS, Bio, YubiHSM, YubiHSM FIPS) ↩