Skip to content

Conversation

@TimLico
Copy link
Contributor

@TimLico TimLico commented Apr 2, 2025

Description

This PR reverts the previous change that removed the 3-second delay on the first connection.

Type of change

  • Refactor (non-breaking change which improves code quality or performance)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test configuration:

  • OS version: e.g. Windows 11
  • Firmware version: e.g. 5.7.2
  • Yubikey model1:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have run dotnet format to format my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Footnotes

  1. See Yubikey models (Multi-protocol, Security Key, FIPS, Bio, YubiHSM, YubiHSM FIPS)

@TimLico TimLico marked this pull request as ready for review April 2, 2025 18:04
@github-actions
Copy link

github-actions bot commented Apr 2, 2025

Test Results: Windows

    2 files      2 suites   6s ⏱️
3 778 tests 3 778 ✅ 0 💤 0 ❌
3 780 runs  3 780 ✅ 0 💤 0 ❌

Results for commit 40f0045.

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

Test Results: Ubuntu

    2 files      2 suites   5s ⏱️
3 770 tests 3 770 ✅ 0 💤 0 ❌
3 772 runs  3 772 ✅ 0 💤 0 ❌

Results for commit 40f0045.

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

Test Results: MacOS

    2 files      2 suites   4s ⏱️
3 770 tests 3 770 ✅ 0 💤 0 ❌
3 772 runs  3 772 ✅ 0 💤 0 ❌

Results for commit 40f0045.

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 40% 31% 4317
Yubico.YubiKey 50% 46% 19635
Summary 48% (33186 / 69264) 44% (8226 / 18903) 23952

Minimum allowed line rate is 40%

@TimLico TimLico requested a review from DennisDyallo April 2, 2025 18:08
@DennisDyallo DennisDyallo merged commit 2b9328d into develop Apr 3, 2025
20 checks passed
@DennisDyallo DennisDyallo deleted the tim/revert-initial-three-seconds-delay-changes branch April 3, 2025 08:12
@DennisDyallo DennisDyallo changed the title Tim/revert initial three seconds delay changes fix: Revert initial three seconds delay changes Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants