Skip to content
This repository was archived by the owner on Oct 4, 2022. It is now read-only.

Conversation

@hansjovis
Copy link
Contributor

@hansjovis hansjovis commented Mar 30, 2021

Summary

This PR can be summarized in the following changelog entry:

  • [schema-blocks] Moves the initialize function to its own file, to clean up the index.ts file of the package.

Relevant technical choices:

  • Moved the initialize function to its own file, to clean up the index.ts file of the package.
    • Its only function is to import and expose functionality, not to implement it.
  • This is needed for the Apply button to work.

Test instructions

This PR can be tested by following these steps:

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    *

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@hansjovis hansjovis added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Mar 30, 2021
@hansjovis hansjovis marked this pull request as ready for review March 30, 2021 08:18
Copy link
Contributor

@andizer andizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR

@johannadevos johannadevos added innovation changelog: other Needs to be included in the 'Other' category in the changelog and removed changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Mar 30, 2021
@johannadevos johannadevos added this to the 16.2 milestone Mar 30, 2021
@johannadevos
Copy link
Contributor

Acceptance: ✅

@johannadevos johannadevos merged commit 0aea553 into develop Mar 30, 2021
@johannadevos johannadevos deleted the P2-674-apply-button-final branch March 30, 2021 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

changelog: other Needs to be included in the 'Other' category in the changelog innovation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants