Skip to content

Fixes typo in integration-guidelines.md #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

mhkuu
Copy link
Contributor

@mhkuu mhkuu commented Jun 10, 2024

Fixes #305

Summary

Fixes a typo on our integration guidelines for schema.

Relevant technical choices

None.

Test instructions

This PR can be acceptance tested by following these steps:

  1. Go to features/schema/integration-guidelines/.
  2. Confirm that $data['type'] = 'Book'; is now $data['@type'] = 'Book';.

Quality assurance

  • Security - I have thought about any security implications this code might add.
  • Performance - I have checked that this code doesn't impact performance (greatly).
  • Caching - I have analyzed the caching methods that this code touches and have added instructions to deal with those.
  • Tested - I have tested this code to the best of my abilities.
  • Automated tests - I have added unit tests to verify the code works as intended.
  • Testability - I have added unique ids to elements, so they can be located in automated testing.
  • I have altered a filename.
    • I have adjusted the ID property accordingly and updated all internal links.
    • I have added the redirect to the _redirects file in the root of the project.

Copy link

Deploying yoast-developer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5d44d5b
Status: ✅  Deploy successful!
Preview URL: https://420216bb.yoast-developer.pages.dev
Branch Preview URL: https://fix-typo-integration-guideli.yoast-developer.pages.dev

View logs

@mhkuu mhkuu merged commit a1d8715 into main Jun 10, 2024
@mhkuu mhkuu deleted the fix/typo-integration-guidelines branch June 10, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo on Integrations Guidelines Page for Schema @type Property
1 participant