Skip to content

Conversation

@wjrjerome
Copy link
Collaborator

@wjrjerome wjrjerome commented Jan 17, 2024

Proposed changes

Update rpc module to handle errors based on the eth PR:

  1. https://github.com/ethereum/go-ethereum/pull/26064/files
  2. https://github.com/ethereum/go-ethereum/pull/26723/files

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@wjrjerome wjrjerome force-pushed the xds-01-fixing-rpc-module branch from 8667859 to 7f02151 Compare January 20, 2024 01:21
@liam-lai liam-lai merged commit 559bb4f into dev-upgrade Jan 22, 2024
@liam-lai liam-lai deleted the xds-01-fixing-rpc-module branch January 22, 2024 06:55
@liam-lai liam-lai mentioned this pull request Feb 4, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants