Add option to control predicate cache, documentation, ArrowReaderMetrics and tests
#7
+660
−71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Merging this PR will update the apache PR apache#7850
Rationale for this change
We need a way to turn off predicate caching as an escape valve for users who run into problems with the cache. This PR adds an option to the
ArrowReaderBuilderto control the predicate cache size.In order to test that this setting actually works, I also wrote tests.
What changes are included in this PR?
Changes:
ArrowReaderMetricsstruct that tracks the IO and CPU operations of the reader.ArrowReaderBuilder::with_max_predicate_cache_sizeconfiguration option to control the predicate cache size.ArrowReaderBuilder::with_metricsfor configuring metricsAre these changes tested?
Yes, all the new code is covered by tests
Are there any user-facing changes?