JAXB Un/marshaller creation, RateLimit, getTrackingCategories #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d safe. So we can use one XeroClient from multiple threads (at least for one Company)
Contributor
|
Thanks @pkohout-profitsee - merged and released as 1.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have updated the XeroJAXBMarshaller to create a new marshaller/unmarshaller on a request basis. Because otherwise it would not be thread safe. And for us (we use one Xero Client per company) It is working in a multi threaded environment. (See XeroJAXBMarshaller.java)
I also added the RateLimit to the XeroApiException. If the rate limit problem occurs, the type (minute/daily) is added to the string, so it is added to the message map. Then you can act accordingly.
(See OAuthRequestResource.java)
And I added the includeArchived parameter in the getTrackingCategories method. (See XeroClient.java)
hope this changes are ok, otherwise please tell me what I should change, we really need this functionallity.
regards Peter