Send a MySQL ping packet by default #2093
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can opt in to setting a command that will be executed on the server, but the default is now a more efficient ping.
bgrainger
force-pushed
the
mysql-ping
branch
from
6dc303b to
e7917f8
Compare
6 tasks
Collaborator
|
The fix got included in #2096 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The previous default behavior for the MySQL health check was to execute
SELECT 1;. This is fairly heavyweight; it would be more efficient to send a MySQL "ping" packet, which is a binary test of server health.MySqlHealthCheckOptions.CommandTextnow defaults tonull, meaning "ping the server". Users can opt in to setting a command that will be executed on the server, but the default is now a more efficient ping.Which issue(s) this PR fixes:
Fixes #2031
Please reference the issue this PR will close: #2031
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Yes; it makes
MySqlHealthCheckOptions.CommandTextnullable and changes its default value; it also makes thehealthQueryparameter toAddMySqlnullable and changes its default value tonull.Please make sure you've completed the relevant tasks for this PR, out of the following list: