Refine must2 and apply NewAesGcm() to all usage #5011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
f61c14e#diff-d38cde35757235c5daf07b808b553c7cd65317cc89c9896c886d91406c76d257R31-R43 |
Member
|
@Fangliding |
Member
Author
以前是config写一个"none" proto里是"none" 现在是 config 写 "none" proto 里是 "" |
Member
|
你测试下好不好用，我测试没啥问题，该有的功能都有且很完善了，客户端一开始并发 1-RTT，收到回复后下次随机选一个 0-RTT 你提的问题，服务端每个 session 都有重放 map，过期会被一起清掉，若找不到 session 就回复非 header，客户端会重新发起握手 |
Member
|
漂亮 |
maoxikun
pushed a commit
to maoxikun/Xray-core
that referenced
this pull request
Aug 23, 2025
* Refine must2 and apply NewAesGcm() to all usage * Remove unused package * Fix test (cherry picked from commit b1107b9)
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
写自己项目的时候用到了类似must2的功能 挺好的 不过看了一下ray里没有用到泛型(如果有泛型可以省略掉断言)
稍微修改了下就没问题了 结果发现项目里并没有大量使用 而是用了很多 must(err) (可能因为懒得断言) 真用must2的时候好像是因为尝试获取一个aead 直接两个if err != nil太麻烦了破防才用的 不过其实核心里有一个封装的直接从key生成aead的函数 顺手全部替换掉了