Skip to content

API: Fix user online map remain 1 after connection dropped #4982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025
Merged

API: Fix user online map remain 1 after connection dropped #4982

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3dc25d4
c.value
LjhAUMEM Aug 4, 2025
d5d8a50
remove value
Aug 5, 2025
1d7a109
c.access.RLock()
Aug 5, 2025
aa24035
remove local var "list"
Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions app/stats/online_map.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (

// OnlineMap is an implementation of stats.OnlineMap.
type OnlineMap struct {
value int
ipList map[string]time.Time
access sync.RWMutex
lastCleanup time.Time
Expand All @@ -25,7 +24,7 @@ func NewOnlineMap() *OnlineMap {

// Count implements stats.OnlineMap.
func (c *OnlineMap) Count() int {
return c.value
return len(c.ipList)
}

// List implements stats.OnlineMap.
Expand All @@ -50,7 +49,6 @@ func (c *OnlineMap) AddIP(ip string) {
c.lastCleanup = time.Now()
}

c.value = len(list)
c.ipList = list
}

Expand Down Expand Up @@ -80,9 +78,8 @@ func (c *OnlineMap) RemoveExpiredIPs(list map[string]time.Time) map[string]time.
}

func (c *OnlineMap) IpTimeMap() map[string]time.Time {
list := c.ipList
if time.Since(c.lastCleanup) > c.cleanupPeriod {
list = c.RemoveExpiredIPs(list)
c.RemoveExpiredIPs(c.ipList)
c.lastCleanup = time.Now()
}

Expand Down
Loading