REALITY client: Fix log when printing "is using X25519MLKEM768..." #4929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
我这里咋好像没问题 |
Member
|
|
Member
|
不过这样改好像不对吧，应该针对 ServerShare，@Fangliding 你看下 |
Member
Author
一样的 你要去 ServerShare 拿的话位置是 c.HandshakeState.ServerHello.ServerShare.group |
Member
Author
|
从 c.curveID 拿已经在 tls ping 命令里经过测试了是没什么问题的 |
RPRX
changed the title
RPRX
changed the title
Member
|
Contributor
其实也可以不靠反射，用 |
Member
|
@wwqgtxx 感觉这样更直观一些， |
This was referenced Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
难道以前一直没人看这个输出吗 我看的时候服务端输出true客户端输出false一头雾水(
selectedGroup 不是服务端选择的group(不同于selected alpn 它确实是服务端给出的alpn协商结果) 这个东西是HelloRetryRequest里用的 服务端想用这个keyshare重新进行协商 而不是说本次握手协商出的keyshare 它直接被编码在 server hello 的keyshare.group 里 所以要像我之前 tls ping 那样反射出来(