fix: update DelegateSet error to tecNO_DELEGATE_PERMISSION

[khancode]

High Level Overview of Change

Update DelegateSet error to tecNO_DELEGATE_PERMISSION

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Tests (You added tests for code that already exists, or your new feature included in this PR)
• Documentation Updates
• Release

Did you update HISTORY.md?

• Yes
• No, this change does not impact library users

Test Plan

Updated integ test.

[coderabbitai]

Walkthrough

This change updates the ripple-binary-codec definitions by adding new fields, ledger entry types, transaction result codes, and transaction types, mainly for vault and batch operations. Additionally, a test was updated to expect a new error code, reflecting the expanded set of transaction result codes. The Node.js versions in workflows and documentation were also updated.

Changes

Files/Paths	Change Summary
packages/ripple-binary-codec/src/enums/definitions.json	Added new fields, ledger entry types, transaction result codes, transaction types, and a new type.
packages/xrpl/test/integration/transactions/delegateSet.test.ts	Updated test to expect "tecNO_DELEGATE_PERMISSION" instead of "tecNO_PERMISSION".
packages/xrpl/test/integration/fundWallet.test.ts	Changed funding amount from 1000 to 100 XRP in test and corresponding assertion.
.github/workflows/nodejs.yml	Updated Node.js versions in CI matrix: dropped 18.x, added 20.x and 22.x; restricted snippets job triggers.
CONTRIBUTING.md	Updated Node.js version requirement from v18 to v22 in development guidelines.
README.md	Updated recommended and tested Node.js versions from v18+ to v20+ and v22.

Possibly related PRs

• XRPLF/xrpl.js#2981: Also extends definitions.json with new fields and transaction types, specifically for delegation and permission features; both PRs modify the same file for related but distinct features.
• XRPLF/xrpl.js#2826: Introduces a script to generate definitions.json from rippled source, directly related to the structure and content updated in this PR.
• XRPLF/xrpl.js#2990: Modifies delegateSet validation and transaction permissions, related to new transaction result codes added here.

Suggested labels

bug

Suggested reviewers

• khancode
• tequdev
• Patel-Raj11

Poem

🐇 In vaults of code where new fields grow,
Batches and ledgers in neat rows show.
Errors named with care,
Tests hop here and there,
Node versions climb, workflows in flow.
The rabbit cheers with a joyful grin,
“New permissions unlocked—let’s begin!” 🌿✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: '@es-joy/[email protected]',
npm warn EBADENGINE required: { node: '^14 || ^16 || ^17 || ^18 || ^19' },
npm warn EBADENGINE current: { node: 'v24.1.0', npm: '11.3.0' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: '[email protected]',
npm warn EBADENGINE required: { node: '^14 || ^16 || ^17 || ^18 || ^19' },
npm warn EBADENGINE current: { node: 'v24.1.0', npm: '11.3.0' }
npm warn EBADENGINE }
npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-05T14_45_30_421Z-debug-0.log

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

README.md (1)

28-28: Add missing comma for clarity.

Insert a comma before the conjunction in the second sentence:

- We also support v20. Other versions may work but are not frequently tested.
+ We also support v20. Other versions may work, but are not frequently tested.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~28-~28: Possible missing comma found.
Context: ...lso support v20. Other versions may work but are not frequently tested. ### Install...

(AI_HYDRA_LEO_MISSING_COMMA)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45a8c97 and 3b8b1cc.

📒 Files selected for processing (4)

• .github/workflows/nodejs.yml (5 hunks)
• CONTRIBUTING.md (1 hunks)
• README.md (1 hunks)
• packages/xrpl/test/integration/fundWallet.test.ts (1 hunks)

✅ Files skipped from review due to trivial changes (3)

• CONTRIBUTING.md
• packages/xrpl/test/integration/fundWallet.test.ts
• .github/workflows/nodejs.yml

🧰 Additional context used

🪛 LanguageTool

README.md

[uncategorized] ~28-~28: Possible missing comma found.
Context: ...lso support v20. Other versions may work but are not frequently tested. ### Install...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: Analyze (javascript)
• GitHub Check: integration (22.x)
• GitHub Check: integration (20.x)
• GitHub Check: browser (22.x)
• GitHub Check: build-and-lint (22.x)
• GitHub Check: unit (20.x)
• GitHub Check: unit (22.x)

🔇 Additional comments (1)

README.md (1)

22-22: Update Node.js version requirement looks good.

Specifying Node.js v20+ aligns with the updated GitHub Actions matrix.