fetch rippled cpp source from github remotes #2937
Conversation
wrap the logic in async method
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
| const path = require('path') | ||
|
|
||
| const fs = require('fs') | ||
| async function readFile(repo, filename) { |
There was a problem hiding this comment.
Please change the name of the repo variable, because it doesn't represent a repo when fetching from a file
|
|
||
| const parts = inp.split('_') | ||
| let result = '' | ||
| for (let x = 0; x < parts.length; x++) { |
There was a problem hiding this comment.
IIRC this is actually incorrect
|
@ckeshava Feel free to reopen this PR to merge into |
2 participants
High Level Overview of Change
This PR includes utility methods to fetch source code from Github remotes. The logic is wrapped in an async-method so that we can use
awaitinside the implementation.Context of Change
Type of Change
Did you update HISTORY.md?
Test Plan