Skip to content

fix: remove Python 3.7 support to fix dependency installation and use 3.8 as new default #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 15, 2024
Merged

fix: remove Python 3.7 support to fix dependency installation and use 3.8 as new default #737

merged 10 commits into from
Aug 15, 2024

Conversation

khancode
Copy link
Contributor

@khancode khancode commented Aug 14, 2024 •
edited
Loading

High Level Overview of Change

Project can no longer build dependencies using Python 3.7. This PR removes Python 3.7 support to fix dependency installation and uses 3.8 as new default.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update CHANGELOG.md?

  • Yes
  • No, this change does not impact library users

Test Plan

@socket-security Socket Security
Copy link

socket-security bot commented Aug 14, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 767 kB Thomas.Grainger, Zac-HD, agronholm, ...2 more
pypi/[email protected] environment, eval, filesystem, shell, unsafe 0 29.4 MB akx, babel, cmlenz, ...2 more
pypi/[email protected] environment, eval, filesystem 0 762 kB Ousret
pypi/[email protected] environment, eval, filesystem, network, shell 0 923 kB
pypi/[email protected] environment, eval, filesystem, network 0 868 kB nedbatchelder
pypi/[email protected] environment, eval, filesystem, shell, unsafe 0 6.9 MB felixwiemann, goodger, grubert, ...1 more
pypi/[email protected] environment, eval, shell 0 131 kB
pypi/[email protected] filesystem 0 72.4 kB gilforcada
pypi/[email protected] environment, filesystem, network Transitive: eval, shell +8 4.64 MB tomchristie
pypi/[email protected] environment, filesystem, unsafe 0 171 kB barry, brettcannon, jaraco
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 45.9 MB ambv, guido, hauntsaninja, ...8 more
pypi/[email protected] environment, eval, filesystem, shell 0 2.4 MB brettcannon, dstufft, pf_moore, ...1 more
pypi/[email protected] filesystem 0 217 kB cpburnz
pypi/[email protected] environment, shell 0 122 kB Julian, Ofekmeister, ronny
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 44.1 MB Anteru, gbrandl, mitsuhiko
pypi/[email protected] environment, filesystem, unsafe 0 1.05 MB stub
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 477 kB Lukasa, graffatcolmingov, nateprewitt
pypi/[email protected] None 0 55.6 kB
pypi/[email protected] environment, filesystem, shell Transitive: eval, network, unsafe +6 7.8 MB tk0miya
pypi/[email protected] environment, filesystem Transitive: eval, network, shell, unsafe +76 22.8 MB tk0miya
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 1.25 MB SethMichaelLarson, shazow
pypi/[email protected] environment, unsafe 0 416 kB Graham.Dumpleton
pypi/[email protected] eval, filesystem, unsafe 0 70.3 kB jaraco

🚮 Removed packages: pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected]

View full report↗︎

@khancode khancode changed the title test branch builds fix: use Python ^3.8 to fix build Aug 14, 2024
@khancode khancode changed the title fix: use Python ^3.8 to fix build fix: remove Python v3.7 (use v3.8 as default) support to fix dependency installation Aug 14, 2024
@khancode khancode changed the title fix: remove Python v3.7 (use v3.8 as default) support to fix dependency installation fix: remove Python 3.7 support to fix dependency installation Aug 14, 2024
@khancode khancode changed the title fix: remove Python 3.7 support to fix dependency installation fix: remove Python 3.7 support to fix dependency installation and use 3.8 as new default Aug 14, 2024
@khancode khancode marked this pull request as ready for review August 14, 2024 17:20
@khancode khancode requested review from ckeshava and pdp2121 August 14, 2024 17:57
khancode added a commit that referenced this pull request Aug 14, 2024
@khancode
remove Python 3.7 support to fix dependency installation and use 3.8 …
76de09f 
…as new default #737
khancode added a commit that referenced this pull request Aug 14, 2024
@khancode
remove python 3.7 from unit test; part of #737
af6ee29
ckeshava
ckeshava reviewed Aug 14, 2024
View reviewed changes
@khancode khancode requested a review from ckeshava August 14, 2024 21:42
ckeshava
ckeshava approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@ckeshava ckeshava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.

there is one more occurence of Python 3.7 in an .rst file (for reference: my custom branch changes it to Python 3.8). That needs to be corrected in your branch

@ckeshava
Copy link
Collaborator

In order to merge this branch, you might have to remove the Branch Protection Rules -- regarding the Python 3.7 CI tests

@khancode
Copy link
Contributor Author

In order to merge this branch, you might have to remove the Branch Protection Rules -- regarding the Python 3.7 CI tests

I updated the rules to remove them, thanks!

@khancode khancode merged commit 17aad31 into main Aug 15, 2024
@khancode khancode deleted the test-branch-builds branch August 15, 2024 20:31
@mvadari mvadari linked an issue Sep 17, 2024 that may be closed by this pull request
Remove support for Python 3.7 #597
Closed
@mvadari mvadari mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckeshava ckeshava ckeshava approved these changes

@pdp2121 pdp2121 pdp2121 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove support for Python 3.7

3 participants

@khancode @ckeshava @pdp2121