Skip to content

Token escrow amendment updates/fixes #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 14, 2025
Merged

Token escrow amendment updates/fixes #3336

merged 9 commits into from
Oct 14, 2025

Conversation

@maria-robobug
Copy link
Contributor

#3260, #3187

  • TokenEscrow updates/fixes for related reference documentation.
  • Updated docs with amendment disclaimer where relevant.

@maria-robobug maria-robobug changed the title Token escrow amendment Token escrow amendment updates/fixes Oct 7, 2025
@maria-robobug maria-robobug force-pushed the token-escrow-amendment branch 4 times, most recently from bc48af5 to ece4883 Compare October 9, 2025 17:56
@maria-robobug maria-robobug force-pushed the token-escrow-amendment branch from ece4883 to 7cdf35f Compare October 9, 2025 17:58
@maria-robobug maria-robobug marked this pull request as ready for review October 9, 2025 17:58
mDuo13
mDuo13 requested changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, necessary improvements, but I did notice a couple places that still need to be changed, and noted several more that you might want to adjust (but are not necessary).

@amarantha-k
Copy link
Collaborator

@maria-robobug Could you also update the detailed section on https://xrpl.org/resources/known-amendments#tokenescrow?

@maria-robobug maria-robobug force-pushed the token-escrow-amendment branch 2 times, most recently from b9aa951 to 76d7880 Compare October 10, 2025 16:37
@maria-robobug maria-robobug force-pushed the token-escrow-amendment branch from 76d7880 to e646e10 Compare October 10, 2025 16:47
@maria-robobug maria-robobug requested a review from mDuo13 October 10, 2025 21:43
mDuo13
mDuo13 previously approved these changes Oct 10, 2025
View reviewed changes
mDuo13
mDuo13 reviewed Oct 10, 2025
View reviewed changes
oeggert
oeggert requested changes Oct 10, 2025
View reviewed changes
Copy link
Collaborator

@oeggert oeggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, got a few small changes requested.

docs/concepts/payment-types/escrow.md

{% admonition type="info" name="Note" %}If the escrow has an expiration time and isn't successfully finished before then, the escrow becomes expired. An expired escrow remains in the ledger until an `EscrowCancel` transaction cancels it, destroying the `Escrow` object and returning the escrowed XRP or fungible tokens to the sender.{% /admonition %}
{% admonition type="info" name="Note" %}
If the escrow has an expiration time and isn't successfully finished before then, the escrow becomes expired. An expired escrow remains in the ledger until an `EscrowCancel` transaction cancels it, returning the escrowed funds to the sender.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can an EscrowCancel transaction come from anybody?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand yes, any account can submit an EscrowCancel transaction.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, EscrowFinish and EscrowCancel transactions can both be sent by anyone as long as the conditions are met (to finish or cancel the escrow, respectively)

Copy link
Collaborator

@oeggert oeggert Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I missed it elsewhere in the doc, it might be worth mentioning that either party can finish the escrow. Not a blocker, though.

@maria-robobug maria-robobug added the needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site label Oct 13, 2025
@maria-robobug maria-robobug force-pushed the token-escrow-amendment branch from 3c56eed to 3136af7 Compare October 13, 2025 10:52
@maria-robobug maria-robobug requested a review from oeggert October 13, 2025 11:17
oeggert
oeggert approved these changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@oeggert oeggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maria-robobug maria-robobug merged commit 62c1d31 into master Oct 14, 2025
4 of 5 checks passed
@maria-robobug maria-robobug deleted the token-escrow-amendment branch October 14, 2025 08:38
@maria-robobug maria-robobug mentioned this pull request Oct 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mDuo13 mDuo13 mDuo13 approved these changes

@oeggert oeggert oeggert approved these changes

@amarantha-k amarantha-k Awaiting requested review from amarantha-k

Assignees

No one assigned

Labels

needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maria-robobug @amarantha-k @mDuo13 @oeggert