Permissioned Domains (XLS-80d)

[oleks-rip]

High Level Overview of Change

Implements the object, transactions, and tests required by the spec: XLS-80d

Context of Change

New feature. Follows existing patterns for adding a new ledger object and related transactions.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

Requires an amendment.

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov]

Codecov Report

Attention: Patch coverage is 96.44444% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (040cd23) to head (70703d9).

Files with missing lines	Patch %	Lines
src/xrpld/rpc/handlers/LedgerEntry.cpp	75.0%	8 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #5161    +/-   ##
========================================
  Coverage     77.9%   77.9%            
========================================
  Files          783     787     +4     
  Lines        66707   66902   +195     
  Branches      8118    8133    +15     
========================================
+ Hits         51954   52132   +178     
- Misses       14753   14770    +17     

Files with missing lines	Coverage Δ
include/xrpl/protocol/Feature.h	100.0% <ø> (ø)
include/xrpl/protocol/Indexes.h	100.0% <ø> (ø)
include/xrpl/protocol/detail/ledger_entries.macro	100.0% <100.0%> (ø)
include/xrpl/protocol/detail/transactions.macro	100.0% <100.0%> (ø)
src/libxrpl/protocol/Indexes.cpp	98.0% <100.0%> (+0.1%)	⬆️
src/xrpld/app/misc/CredentialHelpers.cpp	94.6% <100.0%> (+1.0%)	⬆️
src/xrpld/app/tx/detail/DepositPreauth.cpp	93.0% <100.0%> (-0.7%)	⬇️
src/xrpld/app/tx/detail/InvariantCheck.cpp	87.8% <100.0%> (+1.3%)	⬆️
src/xrpld/app/tx/detail/InvariantCheck.h	100.0% <ø> (ø)
...c/xrpld/app/tx/detail/PermissionedDomainDelete.cpp	100.0% <100.0%> (ø)
... and 6 more

... and 8 files with indirect coverage changes

[Bronek]

You need to fix mac errors; these are happening because clang 15 does not fully implement construction of aggregates in the context where std::construct_at needs them to work, which is ret.emplace_back in src/test/jtx/impl/permissioned_domains.cpp, trying to create AuthorizeCredentials defined in src/test/jtx/deposit.h

Here's small repro with this compiler version, to help you experiment with workarounds https://godbolt.org/z/MKfYfsvan

[mvadari]

Permissioned Domain object should be added to the deletionBlockers list in account_objects

[oleks-rip]

Permissioned Domain object should be added to the deletionBlockers list in account_objects

It is https://github.com/XRPLF/rippled/pull/5161/files#diff-f9abeaf1d1e3337a016d4887673dea0904141a1effb933e0929da383ebacb348R228

[mvadari]

@bthomee this is ready to merge