Skip to content

Commit 3863b01

Browse files
committed
Merge remote-tracking branch 'upstream/develop' into relay
* upstream/develop: Remove flow assert: (5009) Update list of maintainers: (4984)
2 parents f67f346 + 5aa1106 commit 3863b01

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

CONTRIBUTING.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,6 @@ existing maintainer without a vote.
200200
* [JoelKatz](https://github.com/JoelKatz) (Ripple)
201201
* [manojsdoshi](https://github.com/manojsdoshi) (Ripple)
202202
* [n3tc4t](https://github.com/n3tc4t) (XRPL Labs)
203-
* [Nik Bougalis](https://github.com/nbougalis)
204203
* [nixer89](https://github.com/nixer89) (XRP Ledger Foundation)
205204
* [RichardAH](https://github.com/RichardAH) (XRPL Labs + XRP Ledger Foundation)
206205
* [seelabs](https://github.com/seelabs) (Ripple)

src/ripple/app/paths/impl/StrandFlow.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -834,7 +834,13 @@ flow(
834834
{
835835
if (actualOut > outReq)
836836
{
837-
assert(0);
837+
// Rounding in the payment engine is causing this assert to
838+
// sometimes fire with "dust" amounts. This is causing issues when
839+
// running debug builds of rippled. While this issue still needs to
840+
// be resolved, the assert is causing more harm than good at this
841+
// point.
842+
// assert(0);
843+
838844
return {tefEXCEPTION, std::move(ofrsToRmOnFail)};
839845
}
840846
if (!partialPayment)

0 commit comments

Comments
 (0)