Skip to content

Commit 5aa1106

Browse files
committed
Remove flow assert: (#5009)
Rounding in the payment engine is causing an assert to sometimes fire with "dust" amounts. This is causing issues when running debug builds of rippled. This issue will be addressed, but the assert is no longer serving its purpose.
1 parent dccf3f4 commit 5aa1106

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/ripple/app/paths/impl/StrandFlow.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -834,7 +834,13 @@ flow(
834834
{
835835
if (actualOut > outReq)
836836
{
837-
assert(0);
837+
// Rounding in the payment engine is causing this assert to
838+
// sometimes fire with "dust" amounts. This is causing issues when
839+
// running debug builds of rippled. While this issue still needs to
840+
// be resolved, the assert is causing more harm than good at this
841+
// point.
842+
// assert(0);
843+
838844
return {tefEXCEPTION, std::move(ofrsToRmOnFail)};
839845
}
840846
if (!partialPayment)

0 commit comments

Comments
 (0)