-
-
Notifications
You must be signed in to change notification settings - Fork 11
added support for accordion directly #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/tw-animate.css
src/tw-animate.css
src/tw-animate.css
|
Also don't steal other people's stuff whenever someone doesn't merge your PR within a few seconds. I know it's not stealing but it's not correct you published your own package just because I didn't merge your PR yet. |
package.json src/tw-animate.css
well I was not stealing, I needed it so I made it, gave you option for namespaces too, coz I knew better options were available, and you chose instead to teach me how npm namespaces and availabilty work and I credited you well at every place |
That's what forks and PRs are for. But give people time to review and merge them.
I did this because your comment seemed a bit rude and unnecessary. |
it wasn't man, sorry if it felt like that, I am creating so many things around shadcn if you go through my repos, so I believe in naming conventions and what not so it was just that, sorry again |
|
I have marked my comments as resolved in the thread, thanks man |
|
Would you mind working together on this instead of having a separate package? I can also revise my decision on the naming, if necessary. This way we can clean up the NPM package mess there currently is around animation packages |
|
I will keep the namespace for now, and would contribute to this package and not advertise mine out in threads and all. It is a good namespace, that I can easily use to create other animations related stuff in future.
|
Uh oh!
There was an error while loading. Please reload this page.