Skip to content

Conversation

@nrjdalal
Copy link
Contributor

@nrjdalal nrjdalal commented Mar 17, 2025

  • this help minimize lines of code added coz of accordion in globals.css
  • support for both radix and bits

@Wombosvideo
Copy link
Owner

Also don't steal other people's stuff whenever someone doesn't merge your PR within a few seconds. I know it's not stealing but it's not correct you published your own package just because I didn't merge your PR yet.

@nrjdalal
Copy link
Contributor Author

Also don't steal other people's stuff whenever someone doesn't merge your PR within a few seconds. I know it's not stealing but it's not correct you published your own package just because I didn't merge your PR yet.

well I was not stealing, I needed it so I made it, gave you option for namespaces too, coz I knew better options were available, and you chose instead to teach me how npm namespaces and availabilty work

and I credited you well at every place

@Wombosvideo
Copy link
Owner

I needed it so I made it

That's what forks and PRs are for. But give people time to review and merge them.

gave you option for namespaces too, coz I knew better options were available, and you chose instead to teach me how npm namespaces and availabilty work

I did this because your comment seemed a bit rude and unnecessary.

@Wombosvideo Wombosvideo merged commit ab392ff into Wombosvideo:main Mar 18, 2025
@nrjdalal
Copy link
Contributor Author

I needed it so I made it

That's what forks and PRs are for. But give people time to review and merge them.

gave you option for namespaces too, coz I knew better options were available, and you chose instead to teach me how npm namespaces and availabilty work

I did this because your comment seemed a bit rude and unnecessary.

it wasn't man, sorry if it felt like that, I am creating so many things around shadcn if you go through my repos, so I believe in naming conventions and what not

so it was just that, sorry again

@nrjdalal
Copy link
Contributor Author

I have marked my comments as resolved in the thread, thanks man

@Wombosvideo
Copy link
Owner

Would you mind working together on this instead of having a separate package? I can also revise my decision on the naming, if necessary. This way we can clean up the NPM package mess there currently is around animation packages

@nrjdalal
Copy link
Contributor Author

nrjdalal commented Mar 18, 2025

I will keep the namespace for now, and would contribute to this package and not advertise mine out in threads and all. It is a good namespace, that I can easily use to create other animations related stuff in future.

  • updated docs in new PR
  • reduce npm bundle size, no more source
  • added keywords

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants