Skip to content

A possible typo and undefined attributes - reportConstraints function #16

@Andrews54757

Description

@Andrews54757

Hello!

Ive been looking through your nice library and I found some puzzling things about the reportConstraints function.

1. Typo

It seems like there might be a typo here where .lenght should be .length

index = _constraints.lenght;

It also seems as if it was not fixed for quite a while.

2. .ta attribute is defined conditionally

The .ta attribute is set in the addConstraint function for the slider, conetwist, and dof types.

constraint.ta = transforma;
constraint.tb = transformb;

The .ta attribute is only used in the reportConstraints function for ALL constraints regardless of type.

while (index--) {
if (_constraints[index]) {
var _constraint = _constraints[index];
var offset_body = _constraint.a;
var transform = _constraint.ta;
var origin = transform.getOrigin();
// add values to report
offset = 1 + i++ * CONSTRAINTREPORT_ITEMSIZE;
constraintreport[offset] = index;
constraintreport[offset + 1] = offset_body.id;
constraintreport[offset + 2] = origin.x;
constraintreport[offset + 3] = origin.y;
constraintreport[offset + 4] = origin.z;
constraintreport[offset + 5] = _constraint.getBreakingImpulseThreshold();
}
}

Therefore, if you create a constraint that does not set the .ta attribute, you will get an error when this function is run:

screen shot 2018-07-31 at 11 52 10 pm

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions