Upstream clocks tests from wasmtime #182
Open
+65
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
approved these changes
Oct 22, 2025
| async fn sleep_10ms() { | ||
| let dur = 10_000_000; | ||
| monotonic_clock::wait_until(monotonic_clock::now() + dur).await; | ||
| monotonic_clock::wait_for(dur).await; |
There was a problem hiding this comment.
I'd expect that this compares the value of monotonic_clock::now before and after each of these awaits in order to test something...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstreams the WASI clocks tests from Wasmtime. This makes progress towards #181, porting a single test to make sure I'm doing things right. Once we land this, I'd like to port the remainder of the tests in bulk.
As I mentioned in #181 as well: I expect there to be some overlap between this test and the existing WASI 0.3 clocks test. Ideally what I'd like to do is finish porting all tests over first, and then move to refactor/de-duplicate some of the tests. My hope is that with that we can unblock Jco from moving onto
wasi-testsuitesooner, delete the WASI 0.3 tests from Wasmtime, and focus more of the effort on updating the shared testsuite here. Thanks!