wasi:[email protected]: Add tests for rename #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingo
force-pushed
the
filesystem-rename
branch
2 times, most recently
from
f4af324 to
fa71fc7
Compare
wingo
changed the title
wingo
force-pushed
the
filesystem-rename
branch
from
fa71fc7 to
7cdab37
Compare
pchickey
approved these changes
Sep 29, 2025
|
|
||
| async fn test_rename(dir: &Descriptor) { | ||
| // rename-at: async func(old-path: string, new-descriptor: borrow<descriptor>, new-path: string) -> result<_, error-code>; | ||
| let mv = |from: &str, to: &str| -> _ { dir.rename_at(from.to_string(), dir, to.to_string()) }; |
There was a problem hiding this comment.
Would be nice to create a child or sibling directory, open it, and get some coverage where the this and new-descriptor are different.
wingo
force-pushed
the
filesystem-rename
branch
from
7cdab37 to
0f8b08b
Compare
wingo
force-pushed
the
filesystem-rename
branch
from
0f8b08b to
9a3ec7c
Compare
wingo
commented
Oct 7, 2025
| panic!("mv . q.txt unexpectedly succeeded"); | ||
| } | ||
| Err(err) => { | ||
| panic!("mv . q.txt: unexpected error {}", err); |
There was a problem hiding this comment.
Fails on Windows with access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.