[Emscripten port] Fix core count logic for Emscripten+pthreads #6350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Feb 27, 2024
| #ifdef __EMSCRIPTEN__ | ||
| #if defined(__EMSCRIPTEN__) && !defined(__EMSCRIPTEN_PTHREADS__) | ||
| // In an Emscripten build without pthreads support, avoid the overhead of | ||
| // including support code for the below runtime checks. |
There was a problem hiding this comment.
If you really to be sure to avoid the cost why not keep the else/endif? That way you are not relying so much on linker magic to do what you hope it will do.
There was a problem hiding this comment.
Good point, thanks, I opened #6355
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
…sembly#6350) Before this all Emscripten builds would use 1 core, but it is important to allow pthreads builds there to use more.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this all Emscripten builds would use 1 core.