Fix #6047, #5271: Support one-line-one-function file format for asyncify lists

[caiiiycuk]

Fixes:

• handleBracketingOperators (src/support/string.h) is broken, and list parsing in asyncify is not functioning correctly. #6047
• Asyncify lists does not work correctly with dots #5271

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@2c0fb8c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6051   +/-   ##
=======================================
  Coverage        ?   42.46%           
=======================================
  Files           ?      498           
  Lines           ?    75709           
  Branches        ?    11841           
=======================================
  Hits            ?    32147           
  Misses          ?    40409           
  Partials        ?     3153           

[kripken]

lgtm with some minor suggestions.

[caiiiycuk]

@kripken I squashed commits into one. Do you think it is worst to change

needToHandleBracketingOperations = delim != "\n";

into opposite?

needToHandleBracketingOperations = delim == ",";

[kripken]

delim != "\n"; seems better to me, as newlines are special: they are the one case that we can just split naively using them, without scoping/bracketing.

[kripken]

@caiiiycuk it looks like this breaks the auto-updater script,

$ ./scripts/auto_update_tests.py lit
[..]
Fatal: Failed opening '%S/asyncify-foo,bar-nl.txt'
[..]
subprocess.CalledProcessError: Command 'binaryen/scripts/foreach.py binaryen/test/lit/passes/asyncify_pass-arg=asyncify-onlylist@foo,bar.wast /tmp/tmptkbv0v5t wasm-opt --asyncify --pass-arg=asyncify-onlylist@@%S/asyncify-foo,bar-nl.txt -S -o -' returned non-zero exit status 1.
[..]
subprocess.CalledProcessError: Command '['/usr/bin/python3', 'binaryen/scripts/update_lit_checks.py', '--binaryen-bin=binaryen/bin', 'binaryen/test/lit/**/*.wast', 'binaryen/test/lit/**/*.wat']' returned non-zero exit status 1.

We should run that in CI, but don't atm, which is how this was missed.

What is %S trying to do there?

[caiiiycuk]

@kripken asyncify-foo,bar-nl.txt is located in the same folder as a test. However, if you just name it without specifying %S, it may not work correctly. This is because the current working directory is the root of the project or even some other folder. After briefly checking the documentation, it seems that %S refers to the source directory (the directory of the file currently being run), and this could potentially resolve the issue. I apologize for not testing it in different folders to confirm.

[caiiiycuk]

Ah, it's not related to different folders. I didn't imagine that I could break the auto-update, but now it seems obvious. Sorry

[kripken]

@caiiiycuk I'm not sure I understand, but it sounds like you have an idea of what went wrong here - do you know how to fix it?

[caiiiycuk]

@kripken https://github.com/WebAssembly/binaryen/pull/6075/files