Skip to content

Addresses issue #342 - Call VRT with minimum parameters. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Addresses issue #342 - Call VRT with minimum parameters. #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c37c9
Addresses issue #342 - Call VRT with minimum parameters.
suratdas Dec 26, 2021
1b17361
Fixed test.
suratdas Dec 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ public class VisualRegressionTrackerConfig {
@NonNull
private final String apiUrl;
@NonNull
private final String project;
@NonNull
private final String apiKey;
@NonNull
private final String branchName;
private final String project;
@Builder.Default
private Boolean enableSoftAssert = false;
private String branchName = null;
@Builder.Default
private String ciBuildId = null;
@Builder.Default
private Boolean enableSoftAssert = false;
@Builder.Default
private int httpTimeoutInSeconds = 10;
}
2 changes: 1 addition & 1 deletion src/test/java/io/visual_regression_tracker/sdk_java/VisualRegressionTrackerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ public void setup() {
"733c148e-ef70-4e6d-9ae5-ab22263697cc",
"XHGDZDFD3GMJDNM87JKEMP0JS1G5",
"develop",
false,
CI_BUILD_ID,
false,
HTTP_TIMEOUT);
vrt = new VisualRegressionTracker(config);
vrtMocked = mock(VisualRegressionTracker.class);
Expand Down