Skip to content

Conversation

lwronski
Copy link
Contributor

@lwronski lwronski commented Mar 15, 2022

No description provided.

@lwronski lwronski force-pushed the bleep-java-version branch from 1151cc0 to 15833ee Compare March 15, 2022 14:55
@lwronski lwronski marked this pull request as ready for review March 15, 2022 15:19
Copy link
Contributor

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changed code looks good!

It would have been great to have a non-regression test for that (in BloopTests say), but all the ways I can think of testing that are quite convoluted, so I'm not sure it's worth it…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Self-started bloop server doesn't start

2 participants