[tls] Fix read/write ignoring error code and requesting more read/write calls #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncham
approved these changes
Aug 22, 2018
bitter
approved these changes
Aug 23, 2018
AndreasReich
added a commit
that referenced
this pull request
Aug 23, 2018
…-hang-on-connection-close-during-readwrite [tls] Fix read/write ignoring error code and requesting more read/write calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer ran into an issue where the TLS connection would randomly hang. I identified this as the culprit: In the unlikely event of a connection loss we would not report this back to mono but instead require more read/write calls. (fogbugz case 1073275)
I'm fairly confident this PR fixes the issue, however it is really hard to get a repro on this bug and I failed so far in writing a minimal regression test.
Backport to 2018.2 will be required