Remove MaxStep from Soccer agents #5310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongruoping
approved these changes
Apr 22, 2021
andrewcoh
approved these changes
Apr 22, 2021
vincentpierre
pushed a commit
that referenced
this pull request
Apr 27, 2021
vincentpierre
pushed a commit
that referenced
this pull request
Apr 27, 2021
vincentpierre
pushed a commit
that referenced
this pull request
Apr 27, 2021
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Soccer Agents had a maxStep of 3000, but the SoccerEnvController would also reset the Agents when a goal was scored or after MaxEnvironmentSteps.
This sets the MaxStep of all Soccer prefab agents to 0.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://forum.unity.com/threads/some-advice-and-suggestions-python-status-maxstep-vs-maxenvironmentsteps-and-ray-sensor-useage.1097416/
Types of change(s)
Checklist
Other comments