Enum reflection sensor #4006
Enum reflection sensor #4006
Conversation
| } | ||
|
|
||
| if (!s_TypeToSensorInfo.ContainsKey(memberType)) | ||
| if (!s_TypeToSensorInfo.ContainsKey(memberType) && !memberType.IsEnum) |
There was a problem hiding this comment.
Another option would be to add enum types to s_TypeToSensorInfo as they're requested. That simplifies the logic a bit later.
vincentpierre
left a comment
vincentpierre
left a comment
There was a problem hiding this comment.
I have a minor comment but looks good to me
| i++; | ||
| } | ||
|
|
||
| writer[i] = knownValue ? 0.0f : 1.0f; |
There was a problem hiding this comment.
This means that the dimension of an enum will be n + 1 where n is the number of possible values.
This might be confusing to users and I think returning an array of zeros when the value was none of the possible ones is fair.
surfnerd
left a comment
surfnerd
left a comment
There was a problem hiding this comment.
agree with @vincentpierre's comment. It seems intuitive to keep the observation all 0's if there was no known enum value selected. Otherwise, looks good.
|
I made those changes, and also figured out how to support Flags. Non-flags will use all zeros for unknown values. Flags will OR the value with each defined flag. |
Proposed change(s)
Allow enums with ObservableAttribute. Since the number of possibilities is known ahead of time, we can treat this as a one-hot encoding.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://jira.unity3d.com/browse/MLA-1007
Types of change(s)
Checklist
Other comments