Skip to content

Use AddComponentMenu for MonoBehaviours #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Use AddComponentMenu for MonoBehaviours #3231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
059832f
Set AddComponentMenu for MonoBehaviours
Jan 15, 2020
c686541
don't add Monitor
Jan 16, 2020
e87b3db
pass componentOrder instead of nesting
Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions UnitySDK/Assets/ML-Agents/Scripts/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
namespace MLAgents
{
/// <summary>
/// Grouping for use in AddComponentMenu (instead of nesting the menus).
/// </summary>
public enum MenuGroup
Copy link
Contributor Author

@chriselion chriselion Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better way to do this / better place to put it?

{
Default=0,
Sensors=50
}
}
3 changes: 3 additions & 0 deletions UnitySDK/Assets/ML-Agents/Scripts/Constants.cs.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions UnitySDK/Assets/ML-Agents/Scripts/DemonstrationRecorder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ namespace MLAgents
/// Demonstration Recorder Component.
/// </summary>
[RequireComponent(typeof(Agent))]
[AddComponentMenu("ML Agents/Demonstration Recorder", (int) MenuGroup.Default)]
public class DemonstrationRecorder : MonoBehaviour
{
public bool record;
Expand Down
2 changes: 2 additions & 0 deletions UnitySDK/Assets/ML-Agents/Scripts/Policy/BehaviorParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ namespace MLAgents
/// <summary>
/// The Factory to generate policies.
/// </summary>
///
[AddComponentMenu("ML Agents/Behavior Parameters", (int) MenuGroup.Default)]
public class BehaviorParameters : MonoBehaviour
{

Expand Down
1 change: 1 addition & 0 deletions UnitySDK/Assets/ML-Agents/Scripts/Sensor/CameraSensorComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

namespace MLAgents.Sensor
{
[AddComponentMenu("ML Agents/Camera Sensor", (int) MenuGroup.Sensors)]
public class CameraSensorComponent : SensorComponent
{
public new Camera camera;
Expand Down
1 change: 0 additions & 1 deletion UnitySDK/Assets/ML-Agents/Scripts/Sensor/ISensor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,4 @@ public static int ObservationSize(this ISensor sensor)
return count;
}
}

}
3 changes: 3 additions & 0 deletions UnitySDK/Assets/ML-Agents/Scripts/Sensor/RayPerceptionSensorComponent2D.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
using UnityEngine;

namespace MLAgents.Sensor
{
[AddComponentMenu("ML Agents/Ray Perception Sensor 2D", (int) MenuGroup.Sensors)]
public class RayPerceptionSensorComponent2D : RayPerceptionSensorComponentBase
{
public override RayPerceptionSensor.CastType GetCastType()
Expand Down
1 change: 1 addition & 0 deletions UnitySDK/Assets/ML-Agents/Scripts/Sensor/RayPerceptionSensorComponent3D.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

namespace MLAgents.Sensor
{
[AddComponentMenu("ML Agents/Ray Perception Sensor 3D", (int) MenuGroup.Sensors)]
public class RayPerceptionSensorComponent3D : RayPerceptionSensorComponentBase
{
[Header("3D Properties", order = 100)]
Expand Down
1 change: 1 addition & 0 deletions UnitySDK/Assets/ML-Agents/Scripts/Sensor/RenderTextureSensorComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

namespace MLAgents.Sensor
{
[AddComponentMenu("ML Agents/Render Texture Sensor", (int) MenuGroup.Sensors)]
public class RenderTextureSensorComponent : SensorComponent
{
public RenderTexture renderTexture;
Expand Down