Skip to content

Conversation

shakenes
Copy link
Contributor

@shakenes shakenes commented Jun 26, 2019

Hi everybody,
I recently ran into issues when processing multiple visual observations that contain both, RGB and grayscale images, with the OpenAI Gym interface.

I edited the _single_step function accordingly and now it should work.

What do you think?

Sorry for the second PR. Apparently, something went wrong with my git settings...

@shihzy
Copy link
Contributor

shihzy commented Jul 1, 2019

hi @shakenes - can you change the branch to Develop from Master?

@shihzy
Copy link
Contributor

shihzy commented Jul 2, 2019

hi @shakenes - just a friendly reminder to change your target branch to Develop. We do not accept direct contributions to Master in this way.

@shakenes shakenes changed the base branch from master to develop July 3, 2019 08:03
@shakenes
Copy link
Contributor Author

shakenes commented Jul 3, 2019

Sorry for the delay. Just changed it!

@shihzy shihzy requested review from awjuliani and ervteng July 9, 2019 20:30
Copy link
Contributor

@awjuliani awjuliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@shihzy shihzy merged commit 1417b9c into Unity-Technologies:develop Jul 11, 2019
@shihzy
Copy link
Contributor

shihzy commented Jul 11, 2019

thank you for your contribution @shakenes!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants