Skip to content

Conversation

@karasusan
Copy link
Collaborator

This pull request updates the build scripts for all supported platforms (Android, iOS, Linux, macOS, and Windows) to set the symbol_level build argument dynamically based on whether a debug or release build is being performed. The main effect is that debug builds now include more debug symbols (symbol_level=1), while release builds include fewer (symbol_level=0). This change helps balance debuggability in debug builds with smaller binary sizes in release builds.

Key changes by theme:

Dynamic Symbol Level Configuration:

  • All platform build scripts (build_libwebrtc_android.sh, build_libwebrtc_ios.sh, build_libwebrtc_linux.sh, build_libwebrtc_macos.sh, build_libwebrtc_win.cmd) now set the symbol_level argument to 1 for debug builds and 0 for release builds, instead of hardcoding the value. [1] [2] [3] [4] [5] [6]

Build Argument Updates:

  • The symbol_level variable is now passed to the gn gen or equivalent build generation commands in all scripts, ensuring consistent symbol level configuration across platforms. [1] [2] [3] [4] [5] [6]

These changes improve the maintainability and consistency of our build process across all platforms.

@karasusan karasusan requested a review from Copilot August 21, 2025 05:06

This comment was marked as outdated.

@karasusan karasusan requested a review from Copilot August 21, 2025 05:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates all platform build scripts to dynamically set the symbol_level build argument based on debug vs release builds, improving the balance between debuggability and binary size across platforms.

  • Sets symbol_level=1 for debug builds and symbol_level=0 for release builds
  • Applies changes consistently across Android, iOS, Linux, macOS, and Windows build scripts
  • Replaces hardcoded symbol_level=0 values with dynamic configuration

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
BuildScripts~/build_libwebrtc_android.sh Adds dynamic symbol_level configuration for both native library and AAR builds
BuildScripts~/build_libwebrtc_ios.sh Implements conditional symbol_level setting for iOS builds
BuildScripts~/build_libwebrtc_linux.sh Adds symbol_level logic to Linux build configuration
BuildScripts~/build_libwebrtc_macos.sh Updates macOS build script with dynamic symbol_level
BuildScripts~/build_libwebrtc_win.cmd Modifies Windows batch script to conditionally set symbol_level

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants