AIRO-1617 Private ros params #348
Conversation
LaurieCheers-unity
requested review from
at669,
hyounesy and
mrpropellers
and removed request for
at669 and
mrpropellers
hyounesy
left a comment
hyounesy
left a comment
There was a problem hiding this comment.
Approved, with a couple optional suggestions
|
|
||
| > Note: As with part 2, you can configure this launch file with a custom IP address or port: | ||
| ```bash | ||
| roslaunch niryo_moveit part_3.launch tcp_ip:=127.0.0.1 tcp_port:=10005 |
There was a problem hiding this comment.
I am wondering if this can become a bit misleading for most users that are not going to use custom IP address and they may try running it? How about just mentioning the parameter rather than the full command line? e.g.
As with part 2, you can configure this launch file with a custom IP address or port using the tcp_ip and tcp_port parameters respectively.
There was a problem hiding this comment.
I felt like it was important to show the syntax for passing in the parameters (the := notation is not exactly guessable).
|
|
||
| > Note: As with previous parts, you can configure this launch file with a custom IP address or port: | ||
| ```bash | ||
| roslaunch niryo_moveit part_4.launch tcp_ip:=127.0.0.1 tcp_port:=10005 |
There was a problem hiding this comment.
same as above. should we include the entire command or just the parameters?
Bringing tutorials up to date with AIRO-1617, namely the removal of params.yaml, and changing the global ROS_IP and ROS_PORT parameters to local parameters tcp_ip and tcp_port.