Modify number of parameter of send function to definitely express intent

mail/mail.py

@@ -9,8 +9,8 @@ def __init__(self, prot, *argv):
     def login(self, account, passwd):
         self.__prot.login(account, passwd)
 
-    def send(self, frm, to, subject, content):
-        self.__prot.send(frm, to, subject, content)
+    def send(self, frm, to, subject, content, attachments=None):
+        self.__prot.send(frm, to, subject, content, attachments)
 
     def quit(self):
         self.__prot.quit()

mail/prot/smtp.py

@@ -1,4 +1,11 @@
 import smtplib
+import os
+import sys
+from email import encoders
+from email.mime.base import MIMEBase
+from email.mime.text import MIMEText
+from email.mime.multipart import MIMEMultipart
+from datetime import date
 
 
 class Smtp:
@@ -19,9 +26,39 @@ def default_setup(self):
     def login(self, account, passwd):
         self.__smtp_obj.login(account, passwd)
 
-    def send(self, frm, to, subject, content):
-        self.__smtp_obj.sendmail(
-            frm, to, 'Subject:' + subject + '\n' + content)
+    def send(self, frm, to, subject, content, attachments):
+        '''
+        @frm str
+        @to list of email. e.g. ['[email protected]', '[email protected]']
+        @subject str
+        @content str
+        @attachments None or list of file path. e.g. ['filePath1', 'filePath2'] 
+        '''
+        msg = MIMEMultipart()
+        msg['From'] = frm
+        msg['To'] = ', '.join(to)
+        msg['Subject'] = subject
+        msg['Date'] = str(date.today())
+        msg.attach(MIMEText(content))
+
+        for filePath in attachments:
+            try:
+                with open(filePath, 'rb') as fp:
+                    file = MIMEBase('application', 'octet-stream')
+                    file.set_payload(fp.read())
+
+                encoders.encode_base64(file)
+                file.add_header('Content-Disposition', 'attachment',
+                filename=os.path.basename(filePath))
+                msg.attach(file)
+            except:
+                print('Unable to open one of attachments. Error: ', sys.exc_info()[0])
+
+        try:
+            self.__smtp_obj.sendmail(frm, to, msg.as_string())
+            print('Send email with attachment success.')
+        except expression as identifier:
+            print('Send with attatchment Error: ', sys.exc_info()[0])
 
     def quit(self):
         self.__smtp_obj.quit()