-
-
Notifications
You must be signed in to change notification settings - Fork 751
Fix interface merging flagged as static #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! Once I get a chance to test this I hope to merge it. From my initial look, it seems perfect. |
|
@aciccarello, do you have any ETA concrening the integration of the pull requests ? We are relying on typedoc for our documentation checks in Babylonjs and I was wondering whether I should introduce a workaround on our side which depends on the time frame of the push. |
|
Sorry no ETA. I've been a bit busy recently. I'd love to merge this soon but not sure when I'll be able to put together a release. |
This resets the specs so tests pass. See TypeStrong#828 for related issue
also adds 10 as a test version
* Update for typescript v3.1.x * Fix isExported flag * update dependencies - typescript to 2.9
|
I messed up the merge but I had to update the spec file in 1853e6f. Other than that, this looked good. |
|
Sweet, THANKS ! let me know once you ll push a new npm and we ll try it ASAP to give you feedback. |
|
@sebavan release is out. Please note that previous "^0.11.1" is not semver compatible with 0.12.0, so you need to manually change the version |
|
Niceeeeee THX |
* Fix interface merging flagged as static * update static interface merging spec
In the current version of typedoc, augmenting classes through interface merging is leading to the isStatic flag being set to true:
I added the corresponding fix and test in the PR. Let me know if you need anything else.