Skip to content

Conversation

@sebavan
Copy link
Contributor

@sebavan sebavan commented Jun 27, 2018

In the current version of typedoc, augmenting classes through interface merging is leading to the isStatic flag being set to true:

export class A {
}

export interface A {
    /**
     * This method will be flagged as static despite being an instance one.
     */
    mergeMethod();
}

I added the corresponding fix and test in the PR. Let me know if you need anything else.

@aciccarello
Copy link
Collaborator

Thanks for the PR! Once I get a chance to test this I hope to merge it. From my initial look, it seems perfect.

@sebavan
Copy link
Contributor Author

sebavan commented Jul 5, 2018

@aciccarello, do you have any ETA concrening the integration of the pull requests ?

We are relying on typedoc for our documentation checks in Babylonjs and I was wondering whether I should introduce a workaround on our side which depends on the time frame of the push.

@aciccarello
Copy link
Collaborator

Sorry no ETA. I've been a bit busy recently. I'd love to merge this soon but not sure when I'll be able to put together a release.

aciccarello and others added 5 commits August 9, 2018 01:04
This resets the specs so tests pass. See TypeStrong#828 for related issue
also adds 10 as a test version
* Update for typescript v3.1.x

* Fix isExported flag

* update dependencies - typescript to 2.9
@aciccarello
Copy link
Collaborator

I messed up the merge but I had to update the spec file in 1853e6f. Other than that, this looked good.

@aciccarello aciccarello merged commit c392b1a into TypeStrong:master Aug 13, 2018
@sebavan
Copy link
Contributor Author

sebavan commented Aug 13, 2018

Sweet, THANKS ! let me know once you ll push a new npm and we ll try it ASAP to give you feedback.

@webmaster128
Copy link

@sebavan release is out. Please note that previous "^0.11.1" is not semver compatible with 0.12.0, so you need to manually change the version

@sebavan
Copy link
Contributor Author

sebavan commented Aug 21, 2018

Niceeeeee THX

mrkurt pushed a commit to mrkurt/typedoc that referenced this pull request Sep 19, 2018
* Fix interface merging flagged as static
* update static interface merging spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants